Closed anarazel closed 2 months ago
There's only one file changed, not sure what 2 PR's would accomplish
There's only one file changed, not sure what 2 PR's would accomplish
There's a reason I submitted it as one :). But if you wanted to separate out the effects of the different changes it could theoretically make sense to split it. But at this stage of the repo that's not what I would go with.
1) split across lines to make it easier to read 2) specify cmake prefix, to find more dependencies 3) use precompiled headers for a substantially faster build 4) generate debug information 5) add lib\amd64 to library path, otherwise kerberos can't be found 6) enable some additional tests
If you'd prefer, I can split this across several PRs.