dpcunningham / exertimer_i4ng_v0

Public Tutorial (from Gary Simon's DesignCourse): Build an exercise interval timer using Ionic4/Angular
0 stars 0 forks source link

adjust spacing/positions of control elements #16

Closed dpcunningham closed 4 years ago

dpcunningham commented 4 years ago

Per the commentary at 49m04s...

The SVG graphic for the circle-progress bar is taking up way too much vertical real estate.

In his project, he solves this problem by modifying source in the underlying ng-circle-progress component: ./node_modules/ng-circle-progress/index.js

...That's a hard way to solve a problem.

However -- there's a "better" (simpler/cleaner) way to do this...

User comments say to try this (in home.page.html):

<div style="height: 60%"> 
<circle-progress (click)="startTimer()" /... ></circle-progress> 
</div>

...and it seems to work pretty darn well, so I think we'll just go with that.

$ git commit -am "Reduced vertical spacing of circle-progress control."