search

dplesca / go-omxremote

browser based omxplayer remote
MIT License
16 stars 5 forks source link

Option to pass to omxplayer like in omx remote app ? #13

Open glucenag opened 4 years ago

glucenag commented 4 years ago

Hey there,

thanks, it works great. One thing though: to have sound through my DAQ I usually pass the option --adev alsa. Do you know of a way to pass it to omxplayer by means of modifying something in your code, or maybe you know how to modify /usr/bin/omxplayer to achieve that ?

Thanks !

Gustavo

dplesca commented 4 years ago

You can use the -omx flag. 

-omx string
        Options to pass to omxplayer (default "-o hdmi")
glucenag commented 4 years ago

Stupid me. Should have read more carefully. Thanks, it's perfect.

Do you plan on implementing volume control ?

dplesca commented 4 years ago

Hi,

Do you mean to have buttons in the interface with volume up/down? I'm not sure how that would look, because in theory volume would not depend on individual video, so it would have to be a separate zone for those controls in the UI.

I'm going to keep this issue open as a feature request and see what I can come up with.

glucenag commented 4 years ago

Hey there.

Yes that's exactly what I mean: up/down buttons. But you're right, I don't know how it would look either.

Since we're at it, if I may express a couple of feature requests. Basically, I feel like the Android app "OMX remote" packs a couple of cool features that yours lacks:

Cheers though, otherwise your app works wonders AND the install was trivial.

dplesca commented 4 years ago

Firstly, thank you for taking the time to make these suggestions. I'll take them one by one.

very fast forward together with normal fast forward (so one goes like a minute and the other one ten minutes in time)

I actually tested something in a previous version, but the interface was just clunky and I ended up pressing up the wrong forward buttons and I scraped it. I'm thinking of something like pressing continuously on the forward button and the forward speed will just increase, unfortunately it's hard to communicate that to omxplayer.

folder view as per the directory tree (in your app, if I give him a movie folder path /movies and in there I have /movies/armagedon/armagedon.mkv and others, in their own folders or not, what happens to me is that it displays all the movie files alongside eachother, as if they all were in /movies. I think I understand the reason for this, but here's where it is absolutely annoying: TV series. In /movies, I have /movies/the office/season 1/episode 1.mkv and all the others, and what happens with your app is that ALL the episodes are just displayed alongside each other, making browsing a nightmare).

This is an issue I actually encountered, so I know what you mean. I'm not a fan of the tree view, however I was thinking of adding the whole path inside the title (possibly behind a cli flag), so at least it might help with the search, but we might end up with gigantic titles, as I have quite long paths.

Secondly, I'm glad you find this little project useful, I've made it to solve a problem I was having and it's been probably the project I've used the most of all I've written over the years.

glucenag commented 4 years ago

Ah, great that you're taking this well.

About fast forward: in any case, I'm never a big fan of having to keep my finger pressed again my smartphone screen. This, in any case, is probably the least important of suggestions I've raised in my opinion.

If you're not a fan of treeview, then how about the following: instead of going arbitrarily deep into folders (starting with the movie folder) to look for movie files, maybe you could just go one step deep and expose everything you find. For those folders where the one-depth layer does not have any move file in it, you could leave them as folders that one can click on, so as to, again, expose everything that's one-layer deep in there. At the very least, this would separate (probably and in most cases) series from movies, for those like me that have everything in the same spot, and I would say it will also separate series from series. What do you think ? (not sure I made myself clear here)