search

dplesca / go-omxremote

browser based omxplayer remote
MIT License
16 stars 5 forks source link

Cannot play movie when movie name base64 encode result contains '/' #3

Closed krizex closed 7 years ago

krizex commented 7 years ago

Since base64 encode may contain '/', it may cause following match failure:

https://github.com/krizex/go-omxremote/blob/master/go-omxremote.go#L104 router.POST("/start/:name", Start)

I have met this issue and I think it's better to use base32 instead of base64.

krizex commented 7 years ago

I have tested PR #4 and it works fine.

dplesca commented 7 years ago

Hi, thanks for the reporting and the fix. I'll check it out as fast as I can and merge it in if everything is alright on my end.

dplesca commented 7 years ago

Thank you for the PR. It has been merged now.

krizex commented 7 years ago 
    ^_^

On Fri, Jul 21, 2017 at 11:50 PM +0800, "Dragos Plesca" notifications@github.com wrote:

Thanks you for the PR. It has been merged now.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or mute the thread.