dqrobotics / learning-dqrobotics-in-matlab

Other
23 stars 7 forks source link

[BUG] Incorrect wording in explanations of lesson 4. #4

Closed lewiswhe closed 1 month ago

lewiswhe commented 1 month ago

Code of Conduct

By submitting this report you automatically agree that you've read and accepted the following conditions.

  1. In the What we have seen so far > Reference frames and pose transformations, the dot product is used rather than multiplication in the definition of a unit dual quaternion.

Expected Removal of the word "dual" and removal of the "." in the equation

bvadorno commented 1 month ago

Thanks, @lewiswhe.

I assigned @mmmarinho to this issue because he designed the lessons, but let's rectify some misconceptions. Every quaternion is a dual quaternion, although not all dual quaternion is a quaternion. See Section 2.2 of [1], notably the explanation after Eq. (2.2.1).

Multiplication and dot product (Eq. 2.2.4 of [1]) are different types of operations. Rigid motions are propagated through regular multiplications. Dot products (sometimes called inner products) are usually used to operate on Plücker lines.

I suggest that you read [1] together with those MATLAB lessons. My 15+ years of experience working on this theory tells me that If you don't get a strong base now, you'll have many gaps that will come back to bite you.

Kind regards, Bruno

[1] B. V. Adorno, “Robot Kinematic Modeling and Control Based on Dual Quaternion Algebra -- Part I: Fundamentals,” Federal University of Minas Gerais, 2017. [Online]. Available: https://hal.archives-ouvertes.fr/hal-01478225v1

mmmarinho commented 1 month ago

Thanks, @lewiswhe.

I've fixed the typos you mentioned. The "dot" product was caused by a font problem with Live scripts propagating font where it shouldn't and I've correctly replaced it with a space.

Thanks for the reference and the advice as welll @bvadorno.