drcika / apc-extension

https://marketplace.visualstudio.com/items?itemName=drcika.apc-extension
MIT License
658 stars 25 forks source link

Not working with the latest VS Code #230

Open Lady-kimi opened 2 weeks ago

Lady-kimi commented 2 weeks ago

free codeee vers

1blckhrt commented 2 weeks ago

Also having this issue as well, I am on Linux Mint 22 with the same VS Code version as seen above.

Erik262 commented 2 weeks ago

Same here on macOS: image

coderguy-21 commented 2 weeks ago

same here on Ubuntu 24.04

Lady-kimi commented 2 weeks ago

It only works to revert to the previous version of VSCode. 1.93

drcika commented 2 weeks ago

unfortunately, it most likely won't work, they made changes that required the extension to be completely rewritten from scratch, I don't have time to devote to expansion right now, maybe there will be something in the future...

Lady-kimi commented 2 weeks ago

unfortunately, it most likely won't work, they made changes that required the extension to be completely rewritten from scratch, I don't have time to devote to expansion right now, maybe there will be something in the future...

Does this happen with every update or only rarely?

drcika commented 2 weeks ago

you could say rare they already shut down https://github.com/iocave/customize-ui with the changes one gets the impression that they do not want extensions of this type

the options I have require a lot of work to implement the functionality in vscode itself and submit a PR in the hope that they will accept or to build all the files and swap with extension on every version change the principle on which it worked until now is no longer easily feasible

I will come to a solution for sure, we will see if it will be appropriate in the form of an extension

Lady-kimi commented 2 weeks ago

you could say rare they already shut down https://github.com/iocave/customize-ui with the changes one gets the impression that they do not want extensions of this type

the options I have require a lot of work to implement the functionality in vscode itself and submit a PR in the hope that they will accept or to build all the files and swap with extension on every version change the principle on which it worked until now is no longer easily feasible

I will come to a solution for sure, we will see if it will be appropriate in the form of an extension

I hope you can return to it when you have time, I think it is a very good extension and I would be happy to make a donation for it.

mattegray commented 2 weeks ago

I have been using this extension to adjust the icon sizes of the Activity Bar... Now I guess I am stuck with these big ass icons... 😢 @drcika Is this the main reason that requires the rewrite?

Screenshot 2024-10-04 at 10 09 44 AM
pirlo17 commented 2 weeks ago

I had to downgrade the vscode to the version: August 2024 (version 1.93) Update 1.93.1 Link I´m using the APC v0.4.1 and it is working properly, I hope it can be fix it soon

jnbooth commented 2 weeks ago

Wow. I forgot how bad VSCode looks without this extension. Agree with @Lady-kimi about donations, but if this is really going to require a full rewrite from scratch, I totally understand wanting to be done with it. Regardless, thank you so much for the work you put into maintaining it for so long.

yannxaver commented 2 weeks ago

@drcika You could set up funding for a rewrite with Polar (https://docs.polar.sh/issue-funding) or something similar

james-elicx commented 2 weeks ago

I just discovered that VS Code has a setting to put the activity bar to the bottom. It doesn't inline it properly at the bottom like I could do with this extension, but at least it means I don't need massive buttons down the side...

image image

It's a shame they seem to be working to prevent these kinds of extensions from working when they add so many nice little quality of life tweaks.

xiao-kousaka commented 2 weeks ago

I didn't update VScode but still got this problem after I switch the "Restore windows" from default all to none. Can anybody explain this ? image

Ender-Wang commented 2 weeks ago

You can rollback https://code.visualstudio.com/updates/v1_93. Some extensions require the latest 1.94 to work such as Python extension from MS, but you can install older one in extension installation page.

raldisk commented 2 weeks ago

I'm currently on version 1.92.2 & APC v 0.4.1, and it works fine.

skeswa commented 2 weeks ago

Your extension is incredibly valuable to me, and many other people posting in this issue thread. Many of us are happy to help with our time and money. I encourage use of something like polar.sh so that more of us can help.

williamjhughes commented 2 weeks ago

I really don't understand what Microsoft's objection to these types of extensions is. They killed Customize UI and now have seemingly killed this. The functionality to do this natively has been requested time after time and they're so against allowing users to do so, I just don't get it. Thank you for your work on this extension, it has been valuable and made VS Code much more bearable to use.

ahmedsomaa commented 2 weeks ago

I am facing the same issue as well. I have been using this extension for almost a year now and it's awesome. I can't really see myself using VS Code without it. Thank you for so much for the extensions and the efforts you put into this. Such a shame from Microsoft to do so.

jnbooth commented 2 weeks ago

@williamjhughes If they're like a company I worked at, it's probably because they don't want to deal with exposing and maintaining the code for that. It makes it a lot harder to do big refactors like whatever this update did.

peterldowns commented 2 weeks ago

Just want to say thank you for the great extension and for all the effort you've put in maintaining it. Definitely made VSCode much nicer to work in. I completely understand not wanting to keep fighting to keep it working, sounds like a frustrating situation for you just as much as for all of us who use the extension.

HiperDoo commented 2 weeks ago

I appreciate the time you've put into this wonderful extension, I use it to remove all the buttons and text from the interface that I don't use, so I have a great setup and I don't want to give it up.

For now the only solution is to downgrade vscode, on Arch Linux I did it this way:

git clone https://aur.archlinux.org/visual-studio-code-bin.git
cd visual-studio-code-bin

# We look for the ID of the last commit with:
# git log --oneline
# 2a6ac3d [visual-studio-code-bin] Update to 1.93.1

git checkout 2a6ac3d
makepkg -si

With this, no configuration or files are lost and there is no need to delete anything (but perhaps downgrading from a later version can obviously cause problems).

ShayBox commented 2 weeks ago

Always sucks to see this kind of stuff happening, but I'd rather never update VSC again or use another editor than lose this functionality :heart:

ahmedsomaa commented 2 weeks ago

@ShayBox That's what I did. I downgraded to 1.93.1 and turned off automatic updates.

{
  "update.mode": "manual",
}
SudarshanVK commented 2 weeks ago

I have just been using this for the last 3 months. I had a Zen setup.. Microsoft had to spoil it.. Time to move to Zed...

darianmorat commented 2 weeks ago

I'll stay in 1.91.1... I'm happy with it glazewm2

Erik262 commented 2 weeks ago

@darianmorat What is the extension name you are using to display the CPU and RAM in your vscode?

ShayBox commented 2 weeks ago

It looks like that's a desktop bar outside of the window

peterldowns commented 2 weeks ago

@drcika is it possible to simply explain what changed / how the latest VSCode broke the extension? Is the issue with the monkey-patching script, or with what can be done after the monkey-patch works? Or both, or neither? Asking because I'd be willing to take a look at fixing it if you have any ideas for what to try.

INGCapaDev commented 2 weeks ago

This is only one extension I would use if I had to choose only one of my current extensions (and the vim one haha), I hope vscode solve this, I will downgrade the vscode extension and probably switch to nvim or another editor.

AurevoirXavier commented 2 weeks ago

I have to say, if you know GitHub Copilot supports the o1-preview/mini models in the VSCode latest version you won't downgrade to 1.93.

{79E9256F-BA1B-452A-B2A1-A632A74B0CDC}

I love this extension, but the o1 models is so powerful. I won't rollback to use 4o model.

SudarshanVK commented 2 weeks ago

I have to say, if you know GitHub Copilot supports the o1-preview/mini models in the VSCode latest version you won't downgrade to 1.93.

{79E9256F-BA1B-452A-B2A1-A632A74B0CDC}

I love this extension, but the o1 models is so powerful. I won't rollback to use 4o model.

I dont get the option to choose the model.. how are you getting that option?

Undisclosed-Information commented 2 weeks ago

If anything, a solution to edit the ".explorer-folders-view" would be really nice, as vscode is trying to ignore thousands of requests to make it customizable: https://github.com/microsoft/vscode/issues/519.

Dark times have come, I guess its time to switch to Neovim.

balduinofernando commented 2 weeks ago

Looks like it's something about ESM Modules. They released a note about this. https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code

drcika commented 2 weeks ago

Looks like it's something about ESM Modules. They released a note about this. https://code.visualstudio.com/updates/v1_94#_esm-is-shipping-for-vs-code

yes exactly that they switched from AMD to ESM and there is no easy way to integrate with vscode the only solution i have right now (btw i didn't get to research) is to build vscode separately and replace all the files that vscode built which means I have to do it for every new version

peterldowns commented 2 weeks ago

@drcika from playing around locally on a macOS machine, it seems like monkey-patching (manually editing by hand for now) the scripts in Visual Studio Code.app/Contents/Resources/app/out/vs/code/electron-main/main.js still works.

Compared to how the APC extension worked before, I notice two things:

I was able to figure out where to put frame: false in the electron browser window options so that it would take effect. In this screenshot, note that I'm using VSCode v1.94.0!

image

This makes me think that there is definitely a path forward to making this extension work again. In the worst case, there's a way for me to build a "vscode-patcher" that can be used to patch any version of VScode with just the UI tweaks that I want.

and there is no easy way to integrate with vscode

Can you say more about this? For what it's worth, I personally don't mind if the way that my vscode appearance is customized is via an extension or via an external patch-then-re-sign tool. Seems like there's a path forward for the latter.

seloner commented 2 weeks ago

I'll stay in 1.91.1... I'm happy with it glazewm2

vscode theme?

darianmorat commented 2 weeks ago

Is GruvDark Theme @seloner Link: https://marketplace.visualstudio.com/items?itemName=darianmorat.darian-theme

feeas commented 1 week ago

https://github.com/be5invis/vscode-custom-css/issues/227

It looks like vscode-custom-css can work in version 1.94.

tadghh commented 1 week ago

its so over boys

scoop uninstall vscodium@1.94.0.24281
scoop install vscodium@1.93.1.24256
scoop hold vscodium
peterldowns commented 1 week ago

@feeas interesting; from reading the source, it looks like that extension also patches the VSCode app, just in a slightly different way (the workbench.html file only).

@drcika I'm willing to spend some time trying to fix this extension for the newer VScode — would you be interested in help? I'm nervous about wasting time doing this since you said that you don't think it can be done anymore. Can you please explain more about why you think this extension cannot be fixed? From the manual testing I did above, and from looking at what vscode-custom-css does, it really does seem like patching the application can still be done, including the electron options that apc-extension modifies.

drcika commented 1 week ago

they just put inport css/js in html, apc extension directly modified main.js, now it's not easy to do, most likely the only option is to replace the whole main.js, which means I have to do it for every version, feel free to contribute to the development if you succeed

Ender-Wang commented 1 week ago

Since Apc is having a hard time, I switched to my previous setup(some extensions I use requires the newest vsc and I cannot keep them at older version forever) that lands me in this setup, it's still minimal but just the title bar is gone and there's a more functional title bar instead of just shows the current project dir: CleanShot_2024-10-09_18-41-22

peterldowns commented 1 week ago

apc extension directly modified main.js, now it's not easy to do, most likely the only option is to replace the whole main.js, which means I have to do it for every version, feel free to contribute to the development if you succeed

@drcika ok, thanks for explaining. I will give it a shot — maybe I'll run into a big problem, maybe I'll figure it out. Thank you again for all of your hard work creating and maintaining this extension for so long! I hope I can figure it out and contribute back :)

abdarker commented 1 week ago

stopped using APC and i am using Custom CSS and JS loader it's works great on any version https://marketplace.visualstudio.com/items?itemName=be5invis.vscode-custom-css

Ender-Wang commented 1 week ago

stopped using APC and i am using Custom CSS and JS loader it's works great on any version marketplace.visualstudio.com/items?itemName=be5invis.vscode-custom-css

Can you share how you hide the title bar and adjust the rest of the UI below that title bar? I tried hide that bar, but got extra 35px blank spot where the title bar was.

Edit: I managed to move the rest of elements upwards 35px to fill the blank where the title bar was, but I got another 35px blank at the bottom (above the status bar).

Edit: I found a glitch that you can hide title bar completely:

  1. CleanShot_2024-10-11_18-39-27

  2. Then set "window.titleBarStyle": "native", you will be prompt to restart, but do not, and you will see your title bar is completely gone like this: CleanShot_2024-10-11_18-26-50

XiaMi-Long commented 1 week ago

If the "apc.imports" functionality is used, custom CSS and JS files should be written into the workbench.js and workbench.esm.html files located in the VSCode installation directory at \resources\app\out\vs\code\electron-sandbox\workbench.

For the CSS files, they should be directly injected into the section of the workbench.esm.html file. Similarly, for the JS files, they should be inserted into the section of the HTML file. Snipaste_2024-10-11_17-14-13

abdarker commented 1 week ago

stopped using APC and i am using Custom CSS and JS loader it's works great on any version marketplace.visualstudio.com/items?itemName=be5invis.vscode-custom-css

Can you share how you hide the title bar and adjust the rest of the UI below that title bar? I tried hide that bar, but got extra 35px blank spot where the title bar was.

Edit: I managed to move the rest of elements upwards 35px to fill the blank where the title bar was, but I got another 35px blank at the bottom (above the status bar).

Edit: I found a glitch that you can hide title bar completely:

  1. CleanShot_2024-10-11_18-39-27
  2. Then set "window.titleBarStyle": "native", you will be prompt to restart, but do not, and you will see your title bar is completely gone like this: CleanShot_2024-10-11_18-26-50

easy! just use custom css and js loader, then open dev tool from "help" then inspect title bar and put custom css hidden property use display none and done. here's watch this guy's video it will help https://youtu.be/9_I0bySQoCs

DeltaRazero commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html?

Ender-Wang commented 1 week ago

So what's the problem of just injecting everything into workbench.esm.html?

The problem is that you should learn yourself and delete Apc, as I was told above. So there's no problem at all.