dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.92k stars 490 forks source link

fix(core): fix disposing univer causing error #2515

Closed wzhudev closed 1 month ago

wzhudev commented 1 month ago

close #2351

Pull Request Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.

Project coverage is 27.16%. Comparing base (adc1e1f) to head (3743632). Report is 1 commits behind head on dev.

Files Patch % Lines
...s/ui/src/views/components/doc-bars/ToolbarItem.tsx 0.00% 3 Missing :warning:
...core/src/services/permission/permission.service.ts 0.00% 2 Missing :warning:
...ages/ui/src/views/components/popup/CanvasPopup.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2515 +/- ## ======================================= Coverage 27.16% 27.16% ======================================= Files 1653 1653 Lines 83358 83357 -1 Branches 17263 17263 ======================================= + Hits 22642 22643 +1 + Misses 60716 60714 -2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link