dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.92k stars 490 forks source link

feat: support props on float dom component #2518

Closed weird94 closed 1 month ago

weird94 commented 1 month ago

close #xxx

Pull Request Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (ca76011) to head (214b8d7).

:exclamation: Current head 214b8d7 differs from pull request most recent head a5fefeb

Please upload reports for the commit a5fefeb to get more accurate results.

Files Patch % Lines
...i/src/services/canvas-float-dom-manager.service.ts 0.00% 3 Missing :warning:
packages/ui/src/views/components/dom/FloatDom.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2518 +/- ## ========================================== - Coverage 27.16% 27.15% -0.02% ========================================== Files 1653 1653 Lines 83357 83358 +1 Branches 17263 17263 ========================================== - Hits 22642 22633 -9 - Misses 60715 60725 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

View Deployment

#9510133989

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟