dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.92k stars 490 forks source link

fix(sheets): bugfix for data-validation and hyper-link #2527

Closed weird94 closed 1 month ago

weird94 commented 1 month ago

close
https://github.com/dream-num/univer-pro/issues/1186 https://github.com/dream-num/univer-pro/issues/1205 https://github.com/dream-num/univer-pro/issues/1179

Pull Request Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 27.15%. Comparing base (8a1bf8d) to head (66e3515). Report is 7 commits behind head on dev.

:exclamation: Current head 66e3515 differs from pull request most recent head 2612d41

Please upload reports for the commit 2612d41 to get more accurate results.

Files Patch % Lines
...er-link-ui/src/controllers/set-range.controller.ts 0.00% 4 Missing :warning:
...ine-render/src/components/sheets/sheet-skeleton.ts 0.00% 2 Missing :warning:
...validation/src/controllers/dv-render.controller.ts 0.00% 1 Missing :warning:
packages/sheets-hyper-link-ui/src/common/util.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2527 +/- ## ========================================== - Coverage 27.15% 27.15% -0.01% ========================================== Files 1654 1654 Lines 83330 83335 +5 Branches 17258 17262 +4 ========================================== + Hits 22626 22627 +1 - Misses 60704 60708 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

View Deployment

#9543916015

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟