dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.92k stars 490 forks source link

ci: disposing unit should not emit error #2529

Closed wzhudev closed 1 month ago

wzhudev commented 1 month ago

close #xxx

Pull Request Checklist

codecov[bot] commented 1 month ago

Codecov Report

Attention: Patch coverage is 12.79762% with 293 lines in your changes missing coverage. Please review.

Project coverage is 27.17%. Comparing base (85e15af) to head (3a50452).

Files Patch % Lines
...ts-ui/src/controllers/menu/permission-menu-util.ts 0.00% 228 Missing :warning:
...ckages/sheets-ui/src/controllers/menu/menu-util.ts 51.61% 30 Missing :warning:
packages/sheets-formula/src/controllers/menu.ts 0.00% 10 Missing :warning:
...workbook-permission/workbook-permission.service.ts 16.66% 10 Missing :warning:
...ges/core/src/services/instance/instance.service.ts 46.15% 7 Missing :warning:
.../services/mark-selection/mark-selection.service.ts 0.00% 4 Missing :warning:
...rksheet-permission/worksheet-permission.service.ts 50.00% 3 Missing :warning:
packages/sheets-thread-comment/src/types/const.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2529 +/- ## ========================================== + Coverage 27.16% 27.17% +0.01% ========================================== Files 1654 1653 -1 Lines 83476 83494 +18 Branches 17356 17363 +7 ========================================== + Hits 22674 22692 +18 Misses 60802 60802 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 month ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link