dream-num / univer

Univer is an open-source productivity tool dev kit helping you integrate spreadsheets, docs and slides into your applications.
https://univer.ai
Apache License 2.0
6.72k stars 581 forks source link

[Bug] Data Rendering Issue After Switching Sheets and Deleting 'sheet-02' Tab #2534

Closed congxiaobai closed 3 months ago

congxiaobai commented 3 months ago

在您提交此问题之前,您是否检查了以下内容?

受影响的包和版本

0.1.14

复现链接

https://github.com/congxiaobai/ubiver-sheet-error

预期行为

1.切换到'sheet-02'页签

  1. 删除'sheet-02'页签
  2. 期望切换到'sheet-01'页签,并保证数据渲染正确

实际行为

切换到了'sheet-01'页签,但是数据渲染不正确。没有进行重绘。

运行环境

No response

系统信息

System: OS: macOS 14.5 CPU: (8) arm64 Apple M1 Memory: 126.83 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node Yarn: 1.22.22 - ~/.nvm/versions/node/v18.17.0/bin/yarn npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm pnpm: 9.0.6 - ~/.nvm/versions/node/v18.17.0/bin/pnpm Browsers: Edge: 126.0.2592.56 Safari: 17.5

univer-bot[bot] commented 3 months ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: [Bug] Data Rendering Issue After Switching Sheets and Deleting 'sheet-02' Tab

Title: [Bug] Data Rendering Issue After Switching Sheets and Deleting 'sheet-02' Tab


Before you submitted this question, did you check the following?

Affected packages and versions

0.1.14

Recurrence link

https://github.com/congxiaobai/ubiver-sheet-error

Expected behavior

  1. Switch to the 'sheet-02' tab
  2. Delete the 'sheet-02' tab
  3. Expect to switch to the 'sheet-01' tab and ensure that the data is rendered correctly.

Actual behavior

I switched to the 'sheet-01' tab, but the data was not rendered correctly. No redrawing occurs.

Running environment

No response

system message

System: OS: macOS 14.5 CPU: (8) arm64 Apple M1 Memory: 126.83 MB / 16.00 GB Shell: 5.9 - /bin/zsh Binaries: Node: 18.17.0 - ~/.nvm/versions/node/v18.17.0/bin/node Yarn: 1.22.22 - ~/.nvm/versions/node/v18.17.0/bin/yarn npm: 9.6.7 - ~/.nvm/versions/node/v18.17.0/bin/npm pnpm: 9.0.6 - ~/.nvm/versions/node/v18.17.0/bin/pnpm Browsers: Edge: 126.0.2592.56 Safari: 17.5

jikkai commented 3 months ago

Our DI library currently does not support React's strict mode.

import React from 'react'
import ReactDOM from 'react-dom/client'
import App from './App.tsx'

ReactDOM.createRoot(document.getElementById('root')!).render(
-  <React.StrictMode>
    <App />
-  </React.StrictMode>,
)
congxiaobai commented 3 months ago

https://github.com/congxiaobai/ubiver-sheet-error I Delete StrickMode code。 But it still happens。

jikkai commented 3 months ago

It seems we need to confirm this issue. @Dushusir

Dushusir commented 3 months ago

Thank you for your feedback. Version 0.1.16 has fixed this. If you still have problems, please reopen the issue