dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.75k stars 476 forks source link

fix(sheets-data-validation): bugfix for data-validation #2562

Closed weird94 closed 2 weeks ago

weird94 commented 2 weeks ago

close https://github.com/dream-num/univer-pro/issues/1244 https://github.com/dream-num/univer-pro/issues/1254 https://github.com/dream-num/univer-pro/issues/1153 https://github.com/dream-num/univer/issues/1949

Pull Request Checklist

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 13.04348% with 20 lines in your changes missing coverage. Please review.

Project coverage is 27.06%. Comparing base (9c4ea35) to head (b9fa4fa).

:exclamation: Current head b9fa4fa differs from pull request most recent head 133ba9d

Please upload reports for the commit 133ba9d to get more accurate results.

Files Patch % Lines
...idation/src/controllers/dv-auto-fill.controller.ts 0.00% 12 Missing :warning:
...ets-data-validation/src/widgets/dropdown-widget.ts 0.00% 3 Missing :warning:
packages/sheets/src/services/ref-range/util.ts 50.00% 3 Missing :warning:
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2562 +/- ## ========================================== - Coverage 27.06% 27.06% -0.01% ========================================== Files 1677 1677 Lines 84749 84763 +14 Branches 17624 17625 +1 ========================================== Hits 22938 22938 - Misses 61811 61825 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 2 weeks ago

View Deployment

#9598134081

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟