dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.68k stars 469 forks source link

feat(formula): add asin function #2620

Open Dushusir opened 1 week ago

Dushusir commented 1 week ago

close #2043(在其他PR修复)

Pull Request Checklist

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 97.26027% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.00%. Comparing base (909f2ee) to head (b83a738). Report is 18 commits behind head on dev.

Files Patch % Lines
...s/engine-formula/src/functions/math/atan2/index.ts 83.33% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2620 +/- ## ========================================== - Coverage 27.40% 27.00% -0.41% ========================================== Files 1707 1722 +15 Lines 85677 87583 +1906 Branches 17906 18350 +444 ========================================== + Hits 23481 23648 +167 - Misses 62196 63935 +1739 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 1 week ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
univer-bot[bot] commented 1 day ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: feat(formula): add asin function

Title: feat(formula): add asin function


close #2043(在其他PR修复)

Pull Request Checklist

oumomomo commented 19 hours ago

ATAN2函数 1、说明语言不对 image

2、=ATAN2(B17,B16),单元格报错无法计算出值 image

3、仅引用一个值(=ATAN2(H43)或者=ATAN2(H43:H44)时进行计算,单元格展示为空,预期应该报错? image

4、输入=ATAN2(-1,-1)无法计算出值 image

5:输入=ATAN2(0,0) 错误码不对 image

univer-bot[bot] commented 19 hours ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

ATAN2 function

  1. The explanation language is wrong image

  2. =ATAN2(B17,B16), the cell reports an error and cannot calculate the value. image

  3. When only one value (=ATAN2(H43) or =ATAN2(H43:H44) is quoted for calculation, the cell is displayed as empty. Is it expected that an error should be reported? image

  4. Input =ATAN2(-1,-1) cannot calculate the value image

5: Input =ATAN2 (0, 0) wrong error code image

Dushusir commented 7 minutes ago

all fixed