dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.68k stars 469 forks source link

feat(sheets-data-validation): daily bugfix for data-validation #2637

Closed weird94 closed 1 day ago

weird94 commented 4 days ago

close https://github.com/dream-num/univer-pro/issues/1363 https://github.com/dream-num/univer-pro/issues/1365 https://github.com/dream-num/univer-pro/issues/1267 https://github.com/dream-num/univer-pro/issues/1339 https://github.com/dream-num/univer-pro/issues/1370 https://github.com/dream-num/univer-pro/issues/1377 https://github.com/dream-num/univer-pro/issues/1391 https://github.com/dream-num/univer-pro/issues/1407

Pull Request Checklist

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 2.31214% with 169 lines in your changes missing coverage. Please review.

Project coverage is 26.95%. Comparing base (909f2ee) to head (5206227). Report is 1 commits behind head on dev.

:exclamation: Current head 5206227 differs from pull request most recent head 9988c8c

Please upload reports for the commit 9988c8c to get more accurate results.

Files Patch % Lines
...n/src/commands/commands/data-validation.command.ts 0.00% 104 Missing :warning:
...ta-validation/src/validators/checkbox-validator.ts 0.00% 16 Missing :warning:
...ckages/ui/src/views/components/sidebar/Sidebar.tsx 0.00% 13 Missing :warning:
...s/render-controllers/skeleton.render-controller.ts 0.00% 9 Missing :warning:
...-ui/src/services/sheet-skeleton-manager.service.ts 0.00% 6 Missing :warning:
packages/core/src/shared/object-matrix.ts 0.00% 4 Missing :warning:
...ets-data-validation/src/widgets/checkbox-widget.ts 0.00% 4 Missing :warning:
...idation/src/controllers/dv-auto-fill.controller.ts 0.00% 3 Missing :warning:
...dation/src/models/sheet-data-validation-manager.ts 0.00% 3 Missing :warning:
...validation/src/controllers/dv-render.controller.ts 0.00% 2 Missing :warning:
... and 3 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2637 +/- ## ========================================== - Coverage 27.40% 26.95% -0.46% ========================================== Files 1707 1695 -12 Lines 85677 85342 -335 Branches 17906 17782 -124 ========================================== - Hits 23481 23002 -479 - Misses 62196 62340 +144 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

View Deployment

#9742805515

🥐 🍔 🥓 🥗 🥘 🌯 🍚 🍛 🍖 🍭 🍧 🍝 🥪 🥖 🍪
Still cooking, please come back later
🥙 🥮 🥨 🌭 🍦 🍙 🍕 🍰 🍮 🍜 🍡 🍱 🍿 🍕 🥟