fix(sheet): dependency error

DR-Univer commented 1 week ago

close #2030

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

github-actions[bot] commented 1 week ago

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

oumomomo commented 6 days ago

问题1： D1引用C1，E1引用D1，修改D1的内容undo后删除C1的内容E1计算结果未更新 2024_7_2 11_34_29 video.webm 2024_7_2 11_35_12 snapshot.json

问题2： C3列输入=sum（A2），A2列输入=sum（A1:C3），C3的计算结果未更新 https://github.com/dream-num/univer/assets/167171356/3fd35caa-0c54-4fb8-975a-6ed7e68172e2

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Question 1: D1 refers to C1, and E1 refers to D1. After modifying the content of D1 undo, the content of C1 is deleted and the calculation result of E1 is not updated. 2024_7_2 11_34_29 video.webm 2024_7_2 11_35_12 snapshot.json

Question 2: Column C3 input =sum(A2), column A2 input =sum(A1:C3), the calculation result of C3 is not updated https://github.com/dream-num/univer/assets/167171356/3fd35caa-0c54-4fb8-975a-6ed7e68172e2

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 3.84615% with 25 lines in your changes missing coverage. Please review.

Project coverage is 27.36%. Comparing base (909f2ee) to head (9c3dd54). Report is 13 commits behind head on dev.

Files	Patch %	Lines
...formula/src/services/dependency-manager.service.ts	0.00%	14 Missing :warning:
...e-formula/src/engine/dependency/dependency-tree.ts	0.00%	6 Missing :warning:
...-formula/src/services/calculate-formula.service.ts	0.00%	2 Missing :warning:
...rmula/src/controllers/update-formula.controller.ts	33.33%	2 Missing :warning:
...ormula/src/engine/dependency/formula-dependency.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #2650 +/- ## ========================================== - Coverage 27.40% 27.36% -0.05% ========================================== Files 1707 1709 +2 Lines 85677 86081 +404 Branches 17906 17990 +84 ========================================== + Hits 23481 23552 +71 - Misses 62196 62529 +333 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oumomomo commented 6 days ago

问题1删除C1的内容后，D1跟E1单元格0的位置不一样（一左一右）

问题2还是可以复现

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Question 1: After deleting the contents of C1, the positions of cell 0 in D1 and E1 are different (one on the left and one on the right)

Problem 2 can still be reproduced

dream-num / univer