dream-num / univer

Univer is an open-source productivity tool dev kit helping you integrate spreadsheets, docs and slides into your applications.
https://univer.ai
Apache License 2.0
6.71k stars 581 forks source link

fix(sheets-ui): ensure context menu does not open on sheets tab when `contextMenu` is set to false #2654

Closed jikkai closed 3 months ago

jikkai commented 3 months ago

close #2653

Pull Request Checklist

github-actions[bot] commented 3 months ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
codecov[bot] commented 3 months ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 26.92%. Comparing base (e5020d7) to head (fe23450). Report is 1 commits behind head on dev.

Files Patch % Lines
...rc/views/sheet-bar/sheet-bar-tabs/SheetBarTabs.tsx 0.00% 6 Missing :warning:
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 2 Missing :warning:
packages/ui/src/controllers/ui/ui.controller.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2654 +/- ## ========================================== - Coverage 27.36% 26.92% -0.44% ========================================== Files 1709 1714 +5 Lines 86068 87507 +1439 Branches 17986 18330 +344 ========================================== + Hits 23551 23564 +13 - Misses 62517 63943 +1426 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.