search

dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.75k stars 476 forks source link

feat(formula): enable cancellation of ongoing formula calculations #2661

Open Dushusir opened 6 days ago

Dushusir commented 6 days ago

Pull Request Checklist

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

Origin Title: feat(formula): enable cancellation of ongoing formula calculations

Title: feat(formula): enable cancellation of ongoing formula calculations

Pull Request Checklist

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 60.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 26.22%. Comparing base (d523db9) to head (4789823). Report is 3 commits behind head on dev.

Files Patch % Lines
.../src/controllers/trigger-calculation.controller.ts 0.00% 5 Missing :warning:
...ges/ui/src/components/progress-bar/ProgressBar.tsx 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2661 +/- ## ========================================== - Coverage 26.27% 26.22% -0.06% ========================================== Files 1683 1684 +1 Lines 89063 89155 +92 Branches 18755 18782 +27 ========================================== - Hits 23403 23382 -21 - Misses 65660 65773 +113 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 6 days ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
zhaolixin7 commented 6 days ago

@Dushusir 停止计算后单元格显示公式但未显示结果，控制台有报错 image 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir After stopping the calculation, the cell displays the formula but no result, and an error is reported on the console. image 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

Dushusir commented 6 days ago

@Dushusir 停止计算后单元格显示公式但未显示结果，控制台有报错 image 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

fixed

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir Image 409-e80a2144-58df-4b74-b9aa- a61659cf8aca.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUi LCJleHAiOjE3MTk5MjMyNTUsIm5iZiI6MTcxOTkyMjk1NSwicGF0aCI6Ii8xNTQyMDcxMjYvMzQ1 MDExNDA5LWU4MGEyMTQ0LTU4ZGYtNGI3NC1iOWFhLWE2MTY1OWNmOGFjYS5wbmc_WC1BbXotQWxnb 3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1 M1BRSzRaQSUyRjIwMjQwNzAyJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1B bXotRGF0ZT0yMDI0MDcwMlQxMjIyMzVaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT05ZmRiOGRmNDg5MDEzMDAwMzM5MjZlZjMzMTkyNzZlZjBjNTVjNGZjMGZmYz MyZjk5ZDdjM2E0Mzc1ZmFkYWM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCZhY3Rvcl9pZD0wJmtleV9pZD0wJnJlcG9faWQ9MCJ9.KlPnQW7GPnEWN_p6i42CSrQSN3rXD4U-QlC 36-bzB9I) 2024_7_2 19_53_05 commands.json 2024_7_2 19_53_05 video.webm

fixed

zhaolixin7 commented 10 hours ago

@Dushusir 1、删除引用B c列 2、未计算完时停止计算 3、删除子表，删除子表后点击任意单元格，表现：白屏 2024_7_8 17_26_35 video.webm

univer-bot[bot] commented 10 hours ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Dushusir 1. Delete the reference to column B and c. 2. Stop the calculation before the calculation is completed. 3. Delete the subtable. After deleting the subtable, click on any cell, the performance will be: white screen 2024_7_8 17_26_35 video.webm