fix(facade): fix implementation of `getWrap` and remove redundant `getWraps` method

jikkai commented 5 days ago

Pull Request Checklist

[x] Related tickets or issues have been linked in the PR description (or missing issue).
[x] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[x] Unit tests have been added for the changes (if applicable).
[x] Breaking changes have been documented (or no breaking changes introduced in this PR).

github-actions[bot] commented 5 days ago

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

codecov[bot] commented 5 days ago

Codecov Report

Attention: Patch coverage is 81.25000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 27.04%. Comparing base (0db9c36) to head (ad6bc0b).

Files	Patch %	Lines
packages/facade/src/apis/facade.ts	86.66%	2 Missing :warning:
packages/core/src/sheets/range.ts	0.00%	1 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #2675 +/- ## ========================================== + Coverage 27.03% 27.04% +0.01% ========================================== Files 1605 1605 Lines 86920 86918 -2 Branches 18327 18328 +1 ========================================== + Hits 23499 23509 +10 + Misses 63421 63409 -12 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

hexf00 commented 5 days ago

getwraps is not a redundant API @jikkai @Dushusir https://developers.google.com/apps-script/reference/spreadsheet/range#getwraps

hexf00 commented 5 days ago

@jikkai Perhaps redundant type annotations should be avoided in TypeScript code?

dream-num / univer