dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.75k stars 476 forks source link

fix(slide): remove duplicated calls to render.engine.setContainer #2688

Closed jikkai closed 3 days ago

jikkai commented 4 days ago

Before: cf293bc3d4a07cbc5386753b16e33552

After: f6e80ee26d88de0fb72a35d7d56326cb

Pull Request Checklist

codecov[bot] commented 4 days ago

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 26.91%. Comparing base (cf584bd) to head (5c76763). Report is 1 commits behind head on dev.

Files Patch % Lines
...es/engine-render/src/render-manager/render-unit.ts 0.00% 1 Missing :warning:
packages/slides-ui/src/slides-ui-plugin.ts 0.00% 1 Missing :warning:
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2688 +/- ## ========================================== + Coverage 26.89% 26.91% +0.01% ========================================== Files 1636 1636 Lines 87994 87989 -5 Branches 18553 18552 -1 ========================================== + Hits 23670 23680 +10 + Misses 64324 64309 -15 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 4 days ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link