dream-num / univer

Univer is an open-source alternative to Google Sheets, Slides, and Docs
https://univer.ai
Apache License 2.0
5.75k stars 476 forks source link

feat(ui): change floating position #2698

Closed wzhudev closed 12 hours ago

wzhudev commented 3 days ago

Pull Request Checklist

wzhudev commented 3 days ago

@zhaolixin7 The mounting point of floating panels have been changed. Please verity that all panels work.

codecov[bot] commented 3 days ago

Codecov Report

Attention: Patch coverage is 0% with 104 lines in your changes missing coverage. Please review.

Project coverage is 26.47%. Comparing base (a2fd4ed) to head (2fcdc85). Report is 6 commits behind head on dev.

Files Patch % Lines
packages/engine-render/src/floating/util.ts 0.00% 84 Missing :warning:
packages/engine-render/src/engine.ts 0.00% 9 Missing :warning:
...eets-ui/src/services/canvas-pop-manager.service.ts 0.00% 4 Missing :warning:
packages/ui/src/views/DesktopApp.tsx 0.00% 4 Missing :warning:
packages/design/src/components/popup/RectPopup.tsx 0.00% 1 Missing :warning:
...es/ui/src/controllers/ui/ui-desktop.controller.tsx 0.00% 1 Missing :warning:
packages/ui/src/services/parts/parts.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #2698 +/- ## ========================================== - Coverage 26.92% 26.47% -0.46% ========================================== Files 1636 1669 +33 Lines 87997 89547 +1550 Branches 18554 18876 +322 ========================================== + Hits 23695 23709 +14 - Misses 64302 65838 +1536 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

github-actions[bot] commented 3 days ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link