univer-bot[bot]
commented
1 month ago Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑🤝🧑👫🧑🏿🤝🧑🏻👩🏾🤝👨🏿👬🏿
Origin Title: [Bug] 浮动dom元素的props传递
Title: [Bug] props transfer of floating dom elements
Before you submitted this question, did you check the following?
- [X] Is this really a problem?
- [X] I've searched Github Issues but haven't found any similar issues.
Affected packages and versions
0.2.2
Recurrence link
When passing props to the floating dom in the SheetCanvasFloatDomManagerService class of @univerjs/sheets-drawing-ui, the props value is taken from _domLayerMap.
However, _domLayerMap only has an assignment process when it passes the addFloatDomToPosition method. This results in that if the layer is added manually, _domLayerMap will have a value only when the addFloatDomToPosition method is passed; if it is loaded from a snapshot, and the addFloatDomToPosition method is not passed, _domLayerMap will have no value and will be entered at the end of loading from the snapshot. drawingAddListener(), as shown below:
In the figure, _drawingAddListener() only takes props directly from _domLayerMap, which is actually empty. At this time, props should be obtained from param (param is the data from the SHEET_DRAWING_PLUGIN plug-in snapshot).
Expected behavior
The props of the floating dom in the SheetCanvasFloatDomManagerService class of @univerjs/sheets-drawing-ui should be able to pass the previous props when loading from the snapshot. Previous props can be obtained from param
Actual behavior
props cannot be passed when loading floating dom from snapshot
Running environment
Chrome
system message
System: OS: Windows 11 10.0.22000 CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400 @ 2.60GHz Memory: 15.98 GB / 31.77 GB Binaries: Node: 20.14.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD npm: 9.6.2 - C:\Program Files\nodejs\npm.CMD pnpm: 9.1.4 - ~\AppData\Roaming\npm\pnpm.CMD Browsers: Edge: Spartan (44.22000.120.0), Chromium (114.0.1823.43) Internet Explorer: 11.0.22000.120
jikkai
weird94
hxguo
在您提交此问题之前，您是否检查了以下内容？
受影响的包和版本
0.2.2
复现链接
在@univerjs/sheets-drawing-ui的SheetCanvasFloatDomManagerService类中向浮动dom传递props时，props值取自_domLayerMap。 但是_domLayerMap只有在经过addFloatDomToPosition方法时才有赋值过程。这就导致如果是手动添加图层，即有经过addFloatDomToPosition方法时_domLayerMap才有值；如果是从快照中加载的，是没有经过addFloatDomToPosition方法，_domLayerMap是没有值的，从快照加载的最终时进入_drawingAddListener()，如下图：
图中_drawingAddListener()内只有直接从_domLayerMap取props，实际上是空的，此时props应当可从param中获取(param是来自SHEET_DRAWING_PLUGIN插件快照的数据)。
预期行为
在@univerjs/sheets-drawing-ui的SheetCanvasFloatDomManagerService类中浮动dom的props在从快照中加载时，应当可以传递之前的props。之前的props可以种param中获取
实际行为
在从快照中加载浮动dom时，props无法传递
运行环境
Chrome
系统信息
System: OS: Windows 11 10.0.22000 CPU: (12) x64 11th Gen Intel(R) Core(TM) i5-11400 @ 2.60GHz Memory: 15.98 GB / 31.77 GB Binaries: Node: 20.14.0 - C:\Program Files\nodejs\node.EXE Yarn: 1.22.19 - ~\AppData\Roaming\npm\yarn.CMD npm: 9.6.2 - C:\Program Files\nodejs\npm.CMD pnpm: 9.1.4 - ~\AppData\Roaming\npm\pnpm.CMD Browsers: Edge: Spartan (44.22000.120.0), Chromium (114.0.1823.43) Internet Explorer: 11.0.22000.120