dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

feat(sheets-data-validation): optimize data-validation error msg #4044

Closed weird94 closed 3 weeks ago

weird94 commented 3 weeks ago

Pull Request Checklist

github-actions[bot] commented 3 weeks ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 3 weeks ago

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 37 seconds
commit  a644df4
info  For more information, [see full report]()

Flaky tests chromium › memory/memory.spec.ts › memory
codecov[bot] commented 3 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 46 lines in your changes missing coverage. Please review.

Project coverage is 32.93%. Comparing base (27eb2d4) to head (a644df4). Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ata-validation/src/validators/decimal-validator.ts 0.00% 9 Missing :warning:
...ages/sheets-data-validation/src/validators/util.ts 0.00% 9 Missing :warning:
...-data-validation/src/validators/whole-validator.ts 0.00% 8 Missing :warning:
...s-data-validation/src/validators/date-validator.ts 0.00% 6 Missing :warning:
...validation/src/validators/text-length-validator.ts 0.00% 6 Missing :warning:
...a-validation/src/validators/base-data-validator.ts 0.00% 3 Missing :warning:
...ges/sheets-data-validation/src/validators/const.ts 0.00% 2 Missing :warning:
...on-ui/src/views/components/date-dropdown/index.tsx 0.00% 1 Missing :warning:
...src/controllers/dv-formula-ref-range.controller.ts 0.00% 1 Missing :warning:
...data-validation/src/validators/custom-validator.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4044 +/- ## ========================================== - Coverage 32.93% 32.93% -0.01% ========================================== Files 2495 2496 +1 Lines 126818 126832 +14 Branches 28398 28401 +3 ========================================== Hits 41766 41766 - Misses 85052 85066 +14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.