dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

fix(sheets-hyper-link): sheet link popup should attach to cell editor #4063

Closed weird94 closed 2 weeks ago

weird94 commented 2 weeks ago

close #xxx

Pull Request Checklist

github-actions[bot] commented 2 weeks ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 2 weeks ago

Playwright test results

passed  18 passed
flaky  1 flaky

Details

stats  19 tests across 9 suites
duration  5 minutes, 8 seconds
commit  18f312b
info  For more information, [see full report]()

Flaky tests chromium › memory/memory.spec.ts › memory
codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (820653c) to head (18f312b). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...sheets-hyper-link-ui/src/services/popup.service.ts 0.00% 10 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4063 +/- ## ========================================== - Coverage 32.95% 32.94% -0.01% ========================================== Files 2497 2497 Lines 126919 126926 +7 Branches 28419 28421 +2 ========================================== Hits 41821 41821 - Misses 85098 85105 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.