fix(sheets-drawing-ui): sheet-drawing memory leak

weird94 commented 2 weeks ago

close https://github.com/dream-num/univer-pro/issues/3296

Pull Request Checklist

[ ] Related tickets or issues have been linked in the PR description (or missing issue).
[ ] Naming convention is followed (do please check it especially when you created new plugins, commands and resources).
[ ] Unit tests have been added for the changes (if applicable).
[ ] Breaking changes have been documented (or no breaking changes introduced in this PR).

github-actions[bot] commented 2 weeks ago

View Deployment

📑 Examples	📚 Storybook
🔗 Preview link	🔗 Preview link

wzhudev commented 2 weeks ago

Marking this as verified because it does not contain logical changes.

github-actions[bot] commented 2 weeks ago

Playwright test results

passed 18 passed
flaky 1 flaky

Details

stats 19 tests across 9 suites
5 minutes, 8 seconds
commit 54a896a
info For more information, [see full report]()

Flaky tests

chromium › memory/memory.spec.ts › memory

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.94%. Comparing base (7550f1c) to head (5b81798).

Files with missing lines	Patch %	Lines
...i/src/services/canvas-float-dom-manager.service.ts	0.00%	5 Missing :warning:
...src/controllers/sheet-drawing-update.controller.ts	0.00%	4 Missing :warning:

Additional details and impacted files

```diff @@ Coverage Diff @@ ## dev #4067 +/- ## ======================================= Coverage 32.94% 32.94% ======================================= Files 2497 2497 Lines 126926 126925 -1 Branches 28421 28420 -1 ======================================= Hits 41821 41821 + Misses 85105 85104 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dream-num / univer