dream-num / univer

Univer is an Isomorphic Full-Stack Framework for Creating and Editing Spreadsheets, Docs, and Slides Across Web and Server
https://univer.ai
Apache License 2.0
7.17k stars 633 forks source link

fix(sheets-formula): other formula register #4073

Closed weird94 closed 6 days ago

weird94 commented 6 days ago

close #xxx

Pull Request Checklist

github-actions[bot] commented 6 days ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 6 days ago

Playwright test results

failed  1 failed
passed  18 passed

Details

stats  19 tests across 9 suites
duration  5 minutes, 38 seconds
commit  f746e4a
info  For more information, see full report

Failed tests chromium › memory/memory.spec.ts › memory
codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 32.99%. Comparing base (9ccdf2a) to head (f746e4a). Report is 2 commits behind head on dev.

Files with missing lines Patch % Lines
...ula/src/services/register-other-formula.service.ts 0.00% 6 Missing :warning:
.../src/controllers/trigger-calculation.controller.ts 0.00% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4073 +/- ## ========================================== - Coverage 32.99% 32.99% -0.01% ========================================== Files 2437 2437 Lines 126777 126781 +4 Branches 28377 28377 ========================================== Hits 41826 41826 - Misses 84951 84955 +4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Dushusir commented 6 days ago

Note Playwright Tests