dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.52k stars 654 forks source link

fix: auto fill should delete dv rules #4075

Closed lumixraku closed 1 week ago

lumixraku commented 2 weeks ago

close https://github.com/dream-num/univer-pro/issues/2432

Pull Request Checklist

github-actions[bot] commented 2 weeks ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 2 weeks ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 48 seconds
commit ย ad68337
info ย For more information, [see full report]()

codecov[bot] commented 2 weeks ago

Codecov Report

Attention: Patch coverage is 0% with 39 lines in your changes missing coverage. Please review.

Project coverage is 33.73%. Comparing base (bf8329f) to head (ad68337). Report is 16 commits behind head on dev.

Files with missing lines Patch % Lines
...ets/src/commands/commands/utils/selection-utils.ts 0.00% 20 Missing :warning:
...tion-ui/src/controllers/dv-auto-fill.controller.ts 0.00% 9 Missing :warning:
packages/core/src/sheets/worksheet.ts 0.00% 5 Missing :warning:
...n/src/commands/commands/data-validation.command.ts 0.00% 3 Missing :warning:
...ckages/sheets-data-validation/src/utils/formula.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4075 +/- ## ========================================== - Coverage 33.76% 33.73% -0.04% ========================================== Files 2457 2457 Lines 127762 127889 +127 Branches 28608 28637 +29 ========================================== Hits 43141 43141 - Misses 84621 84748 +127 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


๐Ÿšจ Try these New Features:

zhaolixin7 commented 1 week ago

@lumixraku ่ฟ™ไธชไธ‹ๆ‹‰ๅกซๅ……ๆœชไฟฎๅค๏ผŒ็ฒ˜่ดดๅŽๆ•ฐๆฎ้ชŒ่ฏไนŸๆœ‰้—ฎ้ข˜ https://github.com/dream-num/univer-pro/issues/2432 2024_11_21 11_58_56 video.webm ้ข„ๆœŸ๏ผš็ฒ˜่ดดๅ’Œๅกซๅ……ๅŽ้€‰ๅŒบ่ขซๆ‹†ๅˆ†ไธบๅคšไธชๅฆ‚ๆˆชๅ›พ image

3016

้€‰ไธญๅ•ๅ…ƒๆ ผๅณ็งปใ€ไธ‹็งปๅŽ๏ผŒ้ข„ๆœŸ๏ผšๅŽŸๅ•ๅ…ƒๆ ผไธๆ˜พ็คบ่พนๆก† ่กจ็Žฐ๏ผšๅŽŸๅ•ๅ…ƒๆ ผไฟ็•™ไบ†่พนๆก† 2024_11_21 14_08_42 video.webm

univer-bot[bot] commented 1 week ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

@lumixraku This drop-down filling has not been fixed, and there is also a problem with data verification after pasting https://github.com/dream-num/univer-pro/issues/2432 2024_11_21 11_58_56 video.webm Expected: After pasting and filling, the selection is split into multiple pieces as shown in the screenshot image

3016

After moving the selected cell to the right or down, expected: the original cell will not display the border. Performance: The original cell retains its border 2024_11_21 14_08_42 video.webm

lumixraku commented 1 week ago

Google sheet ่‡ชๅŠจๅกซๅ……ๅฏไปฅๅคๅˆถ็Žฐๆœ‰็š„ๆ•ฐๆฎ้ชŒ่ฏ้…็ฝฎ

univer-bot[bot] commented 1 week ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

Google sheet autofill can copy existing data validation configuration