dream-num / univer

Univer is an Isomorphic Full-Stack Framework for Creating and Editing Spreadsheets, Docs, and Slides Across Web and Server
https://univer.ai
Apache License 2.0
7.18k stars 634 forks source link

feat(docs-mention-ui): support doc mention #4093

Closed weird94 closed 2 days ago

weird94 commented 3 days ago

Break changes

  1. thread-comment-mention-data.service was removed, please use mention-io.service instead.

Pull Request Checklist

github-actions[bot] commented 2 days ago

View Deployment

πŸ“‘ Examples πŸ“š Storybook
πŸ”— Preview link πŸ”— Preview link
github-actions[bot] commented 2 days ago

Playwright test results

passed Β 19 passed

Details

stats Β 19 tests across 9 suites
duration Β 4 minutes, 38 seconds
commit Β 4dad32b
info Β For more information, [see full report]()

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 15.00000% with 34 lines in your changes missing coverage. Please review.

Project coverage is 33.05%. Comparing base (05a491b) to head (4dad32b). Report is 4 commits behind head on dev.

Files with missing lines Patch % Lines
...-mention-ui/src/views/mention-edit-popup/index.tsx 0.00% 13 Missing :warning:
...mment-ui/src/views/thread-comment-editor/index.tsx 0.00% 6 Missing :warning:
...s/docs-mention-ui/src/views/mention-list/index.tsx 0.00% 5 Missing :warning:
...rc/services/mention-io/mention-io-local.service.ts 20.00% 4 Missing :warning:
...on-ui/src/commands/commands/doc-mention.command.ts 0.00% 2 Missing :warning:
.../src/controllers/doc-mention-trigger.controller.ts 0.00% 2 Missing :warning:
...ntion-ui/src/services/doc-mention-popup.service.ts 0.00% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4093 +/- ## ======================================= Coverage 33.04% 33.05% ======================================= Files 2437 2438 +1 Lines 126822 126826 +4 Branches 28395 28393 -2 ======================================= + Hits 41912 41920 +8 + Misses 84910 84906 -4 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.


🚨 Try these New Features: