dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

refactor(data-validation): data validation validator #4141

Closed weird94 closed 1 week ago

weird94 commented 1 week ago
  1. Simplify sheet validator
  2. add offsetFormulaByRanges
  3. support developer to register their custom validator

Pull Request Checklist

github-actions[bot] commented 1 week ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 1 week ago

Playwright test results

failed  1 failed
passed  19 passed

Details

stats  20 tests across 9 suites
duration  5 minutes, 46 seconds
commit  919ac8f
info  For more information, see full report

Failed tests chromium › memory/memory.spec.ts › memory
codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 119 lines in your changes missing coverage. Please review.

Project coverage is 33.77%. Comparing base (ae027eb) to head (919ac8f). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...a-validation/src/validators/base-data-validator.ts 0.00% 49 Missing :warning:
...s/sheets-data-validation/src/models/rule-matrix.ts 0.00% 18 Missing :warning:
...s-data-validation/src/services/dv-cache.service.ts 0.00% 11 Missing :warning:
...s-data-validation/src/validators/list-validator.ts 0.00% 7 Missing :warning:
...src/controllers/dv-formula-ref-range.controller.ts 0.00% 3 Missing :warning:
...idation/src/controllers/dv-ref-range.controller.ts 0.00% 3 Missing :warning:
...lidation/src/services/dv-custom-formula.service.ts 0.00% 3 Missing :warning:
...data-validation/src/services/dv-formula.service.ts 0.00% 3 Missing :warning:
...ckages/sheets-data-validation/src/utils/formula.ts 0.00% 3 Missing :warning:
...validation/src/validators/text-length-validator.ts 0.00% 3 Missing :warning:
... and 11 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4141 +/- ## ========================================== + Coverage 33.73% 33.77% +0.04% ========================================== Files 2457 2457 Lines 127893 127725 -168 Branches 28638 28605 -33 ========================================== Hits 43141 43141 + Misses 84752 84584 -168 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.