dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

fix: selection should stop response after a popup shown #4156

Closed lumixraku closed 4 days ago

lumixraku commented 1 week ago

close https://github.com/dream-num/univer-pro/issues/3392

Pull Request Checklist

github-actions[bot] commented 1 week ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 1 week ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 49 seconds
commit ย 2fb4444
info ย For more information, [see full report]()

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 0% with 57 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (fe472fb) to head (2fb4444). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
packages/engine-render/src/engine.ts 0.00% 33 Missing :warning:
packages/engine-render/src/scene.input-manager.ts 0.00% 7 Missing :warning:
packages/engine-render/src/base-object.ts 0.00% 5 Missing :warning:
packages/engine-render/src/scene.ts 0.00% 5 Missing :warning:
packages/engine-render/src/shape/scroll-bar.ts 0.00% 2 Missing :warning:
...services/selection/doc-selection-render.service.ts 0.00% 1 Missing :warning:
...kages/docs-ui/src/services/selection/text-range.ts 0.00% 1 Missing :warning:
...ender/src/render-manager/render-manager.service.ts 0.00% 1 Missing :warning:
...ers/render-controllers/scroll.render-controller.ts 0.00% 1 Missing :warning:
...src/services/selection/selection-render.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4156 +/- ## ========================================== + Coverage 33.76% 33.78% +0.01% ========================================== Files 2486 2485 -1 Lines 127614 127546 -68 Branches 28584 28593 +9 ========================================== Hits 43092 43092 + Misses 84522 84454 -68 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.