dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

fix(formula): update formula data model #4159

Closed Dushusir closed 4 days ago

Dushusir commented 1 week ago

What's updated?

How to test?

Test any formula-related use cases

For example

Pull Request Checklist

github-actions[bot] commented 1 week ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 1 week ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 50 seconds
commit ย 918e35b
info ย For more information, [see full report]()

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 61.11111% with 35 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (81cf367) to head (918e35b). Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...es/engine-formula/src/models/formula-data.model.ts 73.23% 19 Missing :warning:
...rmula/src/controllers/update-formula.controller.ts 0.00% 9 Missing :warning:
...ta-validation/src/services/dv-validator-service.ts 0.00% 2 Missing :warning:
...ui/src/controllers/formula-clipboard.controller.ts 33.33% 2 Missing :warning:
.../src/controllers/formula-editor-show.controller.ts 0.00% 2 Missing :warning:
...gine-formula/src/models/utils/formula-data-util.ts 66.66% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4159 +/- ## ========================================== + Coverage 33.77% 33.78% +0.01% ========================================== Files 2487 2487 Lines 127668 127621 -47 Branches 28601 28583 -18 ========================================== Hits 43121 43121 + Misses 84547 84500 -47 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.