dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

refactor(conditional-formatting): init #4164

Closed Gggpound closed 5 days ago

Gggpound commented 1 week ago

close #xxx

Pull Request Checklist

github-actions[bot] commented 1 week ago

View Deployment

📑 Examples 📚 Storybook
🔗 Preview link 🔗 Preview link
github-actions[bot] commented 1 week ago

Playwright test results

passed  20 passed

Details

stats  20 tests across 9 suites
duration  4 minutes, 48 seconds
commit  903db94
info  For more information, [see full report]()

zhaolixin7 commented 6 days ago

@Gggpound 1、数据条百分比、公式等设置最大最小值时数据条渲染错误,预期:不符合的单元格不显示数据条

截屏2024-11-27 17 54 24

image 2、数据条中数据有0时,预期:不显示数据条 image 3、色阶最大最小值为公式时渲染结果不对(截图右侧是线上的表现)

截屏2024-11-27 19 06 51

4、条件格式自定义公式,符合条件单元格未高亮 预期:截图单元格C1高亮显示(线上有高亮,截图中相同配置数据验证符合条件未报错) 2024_11_27 20_11_25 snapshot.json image

univer-bot[bot] commented 6 days ago

Bot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

@Gggpound 1. The data bar rendering error occurs when the maximum and minimum values ​​of data bar percentages, formulas, etc. are set. Expected: Data bars are not displayed for cells that do not meet the requirements.

Screenshot 2024-11-27 17 54 24

image

  1. When the data in the data bar contains 0, it is expected that the data bar will not be displayed. image
  2. When the maximum and minimum values ​​of the color scale are formulas, the rendering result is incorrect (the right side of the screenshot is the online performance) Screenshot 2024-11-27 19 06 51
  3. Conditional formatting custom formula, cells that meet the conditions are not highlighted Expected: Cell C1 in the screenshot is highlighted (there is a highlight on the line, and the same configuration data in the screenshot is verified to meet the conditions and no error is reported) 2024_11_27 20_11_25 snapshot.json image
codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 49.63768% with 278 lines in your changes missing coverage. Please review.

Project coverage is 33.78%. Comparing base (1a9f83d) to head (903db94). Report is 6 commits behind head on dev.

Files with missing lines Patch % Lines
...odels/calculate-unit-v2/icon-set-calculate-unit.ts 1.61% 61 Missing :warning:
...src/models/conditional-formatting-view-model-v2.ts 70.27% 44 Missing :warning:
...services/conditional-formatting-formula.service.ts 5.26% 36 Missing :warning:
...odels/calculate-unit-v2/data-bar-calculate-unit.ts 61.90% 32 Missing :warning:
...tting-ui/src/controllers/cf.viewport.controller.ts 0.00% 28 Missing :warning:
...calculate-unit-v2/highlight-cell-calculate-unit.ts 46.51% 23 Missing :warning:
...matting-ui/src/controllers/cf.render.controller.ts 0.00% 11 Missing :warning:
...ing/src/services/conditional-formatting.service.ts 47.61% 11 Missing :warning:
...rc/models/calculate-unit-v2/base-calculate-unit.ts 87.27% 7 Missing :warning:
...ing-ui/src/controllers/cf.copy-paste.controller.ts 0.00% 6 Missing :warning:
... and 5 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4164 +/- ## ======================================= Coverage 33.77% 33.78% ======================================= Files 2457 2457 Lines 127720 127630 -90 Branches 28604 28596 -8 ======================================= - Hits 43139 43121 -18 + Misses 84581 84509 -72 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.