dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

fix: selection expand with shift #4166

Closed lumixraku closed 1 day ago

lumixraku commented 6 days ago

close https://github.com/dream-num/univer-pro/issues/3537 close https://github.com/dream-num/univer-pro/issues/3524

close https://github.com/dream-num/univer-pro/issues/3576

Pull Request Checklist

github-actions[bot] commented 6 days ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 6 days ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 49 seconds
commit ย 6a534c1
info ย For more information, [see full report]()

codecov[bot] commented 6 days ago

Codecov Report

Attention: Patch coverage is 26.66667% with 44 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (1de083c) to head (6a534c1). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...ts-formula-ui/src/controllers/prompt.controller.ts 0.00% 14 Missing :warning:
...src/services/selection/selection-render.service.ts 0.00% 8 Missing :warning:
...ts/src/services/selections/selection-data-model.ts 50.00% 8 Missing :warning:
...s/render-services/ref-selections.render-service.ts 0.00% 6 Missing :warning:
...rc/services/selection/selection-shape-extension.ts 0.00% 3 Missing :warning:
...sheets-ui/src/controllers/move-range.controller.ts 0.00% 1 Missing :warning:
...heets-ui/src/controllers/utils/selections-tools.ts 0.00% 1 Missing :warning:
...ervices/selection/base-selection-render.service.ts 0.00% 1 Missing :warning:
...ets-ui/src/services/selection/selection-control.ts 0.00% 1 Missing :warning:
.../src/services/selections/ref-selections.service.ts 0.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4166 +/- ## ========================================== + Coverage 33.67% 33.68% +0.01% ========================================== Files 2490 2490 Lines 128019 128028 +9 Branches 28692 28695 +3 ========================================== + Hits 43105 43128 +23 + Misses 84914 84900 -14 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

oumomomo commented 5 days ago

https://github.com/dream-num/univer-pro/issues/3537

้—ฎ้ข˜1ใ€ ้€‰ไธญ่กŒไฝœไธบๅ…ฌๅผ้€‰ๅŒบๅŽไฝฟ็”จshift+ๅทฆๅณ้”ฎ ้€‰ไธญๅˆ—ไฝœไธบๅ…ฌๅผ้€‰ๅŒบๅŽไฝฟ็”จshift+ไธŠไธ‹้”ฎ

้ข„ๆœŸ่กจ็Žฐ๏ผšๆ— ๆณ•่ฐƒๆ•ด้€‰ๅŒบ ๅฎž้™…่กจ็Žฐ๏ผšๅฏไปฅ่ฐƒๆ•ด้€‰ๅŒบ๏ผŒไธ”่ฐƒๆ•ด้€‰ๅŒบๅŽ่ƒŒๆ™ฏ่‰ฒ่ถ…ๅ‡บ 2024_11_29 11_42_49 video.webm

univer-bot[bot] commented 5 days ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

https://github.com/dream-num/univer-pro/issues/3537

Question 1. After selecting the row as a formula selection, use shift + left and right keys After selecting a column as a formula selection, use shift+up and down keys

Expected performance: Unable to adjust selection Actual performance: The selection can be adjusted, and the background color exceeds the 2024_11_29 11_42_49 video.webm

univer-bot[bot] commented 5 days ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

https://github.com/dream-num/univer-pro/issues/3537 Question 2: When Table 1 refers to the selection of Table 2 across tables, the selection cannot be adjusted using shift+arrow keys. 2024_11_29 11_46_54 video.webm

Expected performance: can be adjusted normally

oumomomo commented 5 days ago

https://github.com/dream-num/univer-pro/issues/3537

้—ฎ้ข˜2ใ€ๅผ•็”จ่กŒๅˆ—ไฝฟ็”จshift+ๆ–นๅ‘้”ฎ

ๅฎž้™…่กจ็Žฐ ๅผ•็”จ่กŒๅˆ—ๆ—ถไฝฟ็”จๆ–นๅ‘้”ฎไผšๅฑ•็คบๅˆ—ๆ ‡้ข˜+่กŒๅบๅท image

excel่กจ็Žฐ๏ผš ๅผ•็”จๅˆ—ๆ—ถไฝฟ็”จๅทฆๅณ้”ฎ่ฐƒๆ•ด้€‰ๅŒบ๏ผŒๅ…ฌๅผๅ†…ไป…ๅฑ•็คบๅˆ—ๆ ‡้ข˜ไธๅฑ•็คบๅ•ๅ…ƒๆ ผๅบๅท 2024_11_29 11_54_45 video.webm image

ๅผ•็”จ่กŒๆ—ถไฝฟ็”จไธŠไธ‹้”ฎ่ฐƒๆ•ด้€‰ๅŒบ๏ผŒไป…ๅฑ•็คบ่กŒๅบๅทไธๅฑ•็คบๅˆ—ๆ ‡้ข˜ image

univer-bot[bot] commented 5 days ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

https://github.com/dream-num/univer-pro/issues/3537

Question 2. Use shift+arrow keys to reference rows and columns.

actual performance When referencing a row or column, using the arrow keys will display the column title + row number. image

excel performance: When referencing a column, use the left and right keys to adjust the selection. Only the column title is displayed in the formula and the cell serial number is not displayed. 2024_11_29 11_54_45 video.webm image

When referencing a row, use the up and down keys to adjust the selection. Only row numbers are displayed and column titles are not displayed. image

univer-bot[bot] commented 5 days ago

Bot detected the issue body's language is not English, translate it automatically. ๐Ÿ‘ฏ๐Ÿ‘ญ๐Ÿป๐Ÿง‘โ€๐Ÿคโ€๐Ÿง‘๐Ÿ‘ซ๐Ÿง‘๐Ÿฟโ€๐Ÿคโ€๐Ÿง‘๐Ÿป๐Ÿ‘ฉ๐Ÿพโ€๐Ÿคโ€๐Ÿ‘จ๐Ÿฟ๐Ÿ‘ฌ๐Ÿฟ

https://github.com/dream-num/univer-pro/issues/3524

Note: After referencing the selection in Table 1, the format is =I21:J25,K27:M32. The comma after the second selection is switched to Table 2 and added, otherwise it cannot be reproduced.

  1. Enter = in the cell of Table 1 to reference the two selections in this table.
  2. Switch to Table 2 input, and then reference a selection
  3. Switch back to Table 1 to view the selection lines 2024_11_29 14_34_14 video.webm

Expected performance: The selection lines in Table 1 are displayed normally. Actual performance: The selection lines in Table 1 are not displayed.