dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

refactor(sheets-ui): cell-editor & formula-editor #4209

Open weird94 opened 2 days ago

weird94 commented 2 days ago

close https://github.com/dream-num/univer-pro/issues/3557 close https://github.com/dream-num/univer-pro/issues/3503 close https://github.com/dream-num/univer-pro/issues/3130 close https://github.com/dream-num/univer-pro/issues/3090 close https://github.com/dream-num/univer-pro/issues/3009 close https://github.com/dream-num/univer-pro/issues/2932 close https://github.com/dream-num/univer-pro/issues/2830 close https://github.com/dream-num/univer-pro/issues/3619 close https://github.com/dream-num/univer-pro/issues/3536

Pull Request Checklist

github-actions[bot] commented 2 days ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 2 days ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 48 seconds
commit ย 5b5716a
info ย For more information, [see full report]()

codecov[bot] commented 2 days ago

Codecov Report

Attention: Patch coverage is 8.18584% with 415 lines in your changes missing coverage. Please review.

Project coverage is 33.62%. Comparing base (3ce3b27) to head (5b5716a). Report is 5 commits behind head on dev.

Files with missing lines Patch % Lines
.../views/formula-editor/hooks/useFormulaSelection.ts 0.00% 48 Missing :warning:
...ws/formula-editor/hooks/useSheetSelectionChange.ts 0.00% 44 Missing :warning:
...eets-formula-ui/src/views/formula-editor/index.tsx 0.00% 44 Missing :warning:
...views/range-selector/hooks/useLeftAndRightArrow.ts 0.00% 44 Missing :warning:
...docs/data-model/text-x/build-utils/text-x-utils.ts 2.85% 34 Missing :warning:
...-ui/src/views/editor-container/EditorContainer.tsx 0.00% 24 Missing :warning:
...i/src/commands/commands/replace-content.command.ts 4.54% 21 Missing :warning:
...src/views/range-selector/hooks/useKeyboardEvent.ts 0.00% 21 Missing :warning:
...ges/sheets-ui/src/views/formula-bar/FormulaBar.tsx 0.00% 16 Missing :warning:
...ages/sheets-ui/src/views/editor-container/hooks.ts 0.00% 15 Missing :warning:
... and 32 more
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4209 +/- ## ========================================== - Coverage 33.67% 33.62% -0.05% ========================================== Files 2490 2493 +3 Lines 128045 128328 +283 Branches 28703 28793 +90 ========================================== + Hits 43114 43151 +37 - Misses 84931 85177 +246 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.