dream-num / univer

Univer is an isomorphic full-stack framework for creating and editing spreadsheets, docs, and slides across client and server.
https://univer.ai
Apache License 2.0
7.53k stars 654 forks source link

fix(formula): fix compare of range and criteria in related formulas #4216

Closed wpxp123456 closed 1 day ago

wpxp123456 commented 1 day ago

close #4153

Pull Request Checklist

github-actions[bot] commented 1 day ago

View Deployment

๐Ÿ“‘ Examples ๐Ÿ“š Storybook
๐Ÿ”— Preview link ๐Ÿ”— Preview link
github-actions[bot] commented 1 day ago

Playwright test results

passed ย 20 passed

Details

stats ย 20 tests across 9 suites
duration ย 4 minutes, 47 seconds
commit ย 18079d3
info ย For more information, [see full report]()

codecov[bot] commented 1 day ago

Codecov Report

Attention: Patch coverage is 89.47368% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.68%. Comparing base (22facae) to head (18079d3). Report is 1 commits behind head on dev.

Files with missing lines Patch % Lines
...es/engine-formula/src/engine/utils/value-object.ts 87.50% 2 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## dev #4216 +/- ## ======================================= Coverage 33.68% 33.68% ======================================= Files 2490 2490 Lines 128028 128037 +9 Branches 28695 28701 +6 ======================================= + Hits 43128 43135 +7 - Misses 84900 84902 +2 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.