Delivery method option region added to generate accurate message_id

drewblas / aws-ses

Provides an easy ruby DSL & interface to AWS SES

MIT License

549 stars 109 forks source link

Closed yeeyee18 closed 5 years ago

yeeyee18 commented 5 years ago

I've added aws region to the delivery_method_options so that the message_id generated matches the one received by email client.

Before: "#{message_id}@emails.amazonses.com" After: "#{message_id}@#{region}.amazonses.com"

drewblas commented 5 years ago

Thanks. Do NO regions use "email" anymore for the message ID? Or is "email" for just us-east-1 or the like?

I just want to be sure that this works correctly for people in all cases

yeeyee18 commented 5 years ago

As far as I know, ses for us-west-2 also have the same {region}.amazonses.com format. AWS doesn't guarantee the format of full message id.

I could make the whole string configurable, in case it changes again.

message_id_domain = us-west-2.amazonses.com Default value for message_id_domain will be email.amazonses.com