search

drewg13 / foundryvtt-band-of-blades

Band of Blades for FoundryVTT
Other
3 stars 5 forks source link

System update: k is not defined #36

Closed orkaboy closed 2 years ago

orkaboy commented 2 years ago

When I run system update (on Band of Blades v1.8.3), I get this (note that the same error is present for the Scum and Villainy system):

image

I'm assuming this is an update to Foundry V10 issue (I'm currently running Stable 9.269). What is the recommended Foundry update channel/version that you are currently running? Also note that the PbtA and DW appears to have similar issues, but they fail more gracefully.

I got a popup when updating to v1.8.3 that the path to the manifest had changed, not sure if related but thought I'd mention it.

orkaboy commented 2 years ago

Just to not send you on a while goose chase, I saw this for some modules as well (not just your systems). I read this from theripper93's Discord for the exact same error message:

Note: Updating my modules will give you this error while you are on V9 if a V10 version is present, you can safely ignore it

drewg13 commented 2 years ago

I was aware of that, although I thought I included the V9 fields needed to not trigger that error. As you guessed, those are V10 updates, but if you look at the changelogs, there's not that much I've added that would be worth upgrading for so far. Maintaining backwards compatibility was unpleasant and needlessly complex with all of the Document API changes, so releasing V10-only versions from here out made the most sense to me. The code is pretty stable and there's nothing major I was planning to add.