search

dro123 / redmine_meeting_room_calendar

Qburst's meeting room plugin for redmine
Other
28 stars 20 forks source link

Unvisible meetings in All view #39

Open sanyimano opened 7 years ago

sanyimano commented 7 years ago

These are the site ifos: Redmine version 3.2.3.stable Ruby version 2.2.6-p396 (2016-11-15) [amd64-freebsd9] Rails version 4.2.7 Environment production Database adapter PostgreSQL Redmine plugins: project_priority 0.0.3 redmine_base_deface 0.0.1 redmine_maintenance_mode 2.0.1 redmine_meeting_room_calendar 3.0.0

I have problem with the All room view, even is day or week selection, certain room bookings does not appear in the view. All bookings are visible when selecting a single room one by one, but some disappear when I select All. Several day are ok, but there are some where deleting/recreating or any other trick does not help. I checked the issues table and I could not see any difference between the visible and invisible issues on the same date. What do I wrong?

dro123 commented 7 years ago

The ones that are missing, are they always the same? Or are they random but always from the same room(s)?

sanyimano commented 7 years ago

The same ones are missing. As right now recognized, that the missing bookings are done for several days for the same period. And also recognized another discrepancy. When All is selected and I do a booking for the room, that is invisible in the view, and the booking is done for an earlier beginning than the invisible booking and where the end time is earlier than the invisible end, it is possible to do an overlapping!!

sanyimano commented 7 years ago

It's an idea only. When repeated booking is done for several day and the process that creates the issues for every individual day something goes wrong. The problem probably is not in the issues table, because there I could not find any difference. But right now I don't know which tables are involved in this process.

sanyimano commented 7 years ago

It seems, that I am wright. For the problematic day I deleted the 'invisible' booking, and I booked it again, as a one day booking it became visible in the All view!

sanyimano commented 7 years ago

And the booking for the other days are still invisible in the All view.

dro123 commented 7 years ago

Could you try what is described here and check if it works with the change? https://github.com/dro123/redmine_meeting_room_calendar/issues/38#issuecomment-250601351

Regarding the overlapping, this does not happen if all the bookings are displayed. So if we fix this, the overlapping can not happen anymore.

sanyimano commented 7 years ago

Getting better. I would say ok except the following things.

sanyimano commented 7 years ago

When using Chrome, and after deleting cookies the views are now OK!! The side effects disappeared. [Ctl-Shift-Del and selecting the checkbox of deleting the cookies] The problem of Edge seems to be an implementation problem of the fullcalendar.min.css::

Thank you for your help! You can close this issue.

dro123 commented 7 years ago

While it works now, this is just a workaround. You will get the same issues after 500 tickets were created. The guy in the other issue had the same problem, but I can't reproduce this and need someone to this for me. If you want to help and solve the issue do this:

Revert the change so that it doesn't work anymore. Then add the following code after "getEventsJSON = function(offset) {" in assets/javascript/meetingcalendar.js: https://github.com/dro123/redmine_meeting_room_calendar/blob/master/assets/javascripts/meetingcalendar.js#L29

alert(offset);

This should bring at least two (maybe more) popups when you refresh the site with numbers in them. Could you give me the numbers it shows?

Otherwise: It's probably a good idea to make the "1000" at least a "10000". That's probably enough to not get into this again.