drsimonj / twidlr

data.frame-based API for model and predict functions
Other
59 stars 9 forks source link

Error in `model_as_xy` #3

Closed drsimonj closed 7 years ago

drsimonj commented 7 years ago

model_as_xy returns mismatched data when missing values are present. E.g., if no missing values in y but some missing values in x's, the missing value rows are removed from x's, but retained in y.

drsimonj commented 7 years ago

This leads to errors in twidlr functions that use this such as glmnet and xgboost