drupalprojects / kalatheme

Mirror of http://drupal.org/project/kalatheme provided by hubdrop.
http://hubdrop.org/project/kalatheme
GNU General Public License v2.0
22 stars 29 forks source link

Cannot save theme settings in 7.x - 3.0 #119

Open maxplus opened 10 years ago

maxplus commented 10 years ago

Hi,

I'm running a clean new site based on Panopoly 7.x-1.6 with Kalatheme 7.x-3.0.

I already have successfully generated a custom subtheme based on a Bootswatch theme without a problem (based on United)

But now I want to edit the theme settings through the theme appearance admin page "admin/appearance/settings" (disable logo, secondary menu,...) but I when I save this form, nothing gets saved.

On top of the "admin/appearance/settings" page of my custom Kalatheme, I keep getting the error message "If you want Kalatheme to be able to use custom Bootstrap libraries or generate subthemes automatically please properly configure your webserver."

Stange, because:

I already cleared caches multiple times, ran Cron multiple times and my custom theme is the only active theme at the moment.

Anyone some advice about this issue?

maxplus commented 10 years ago

Hi,

maybe nice to know for others with this problem:

I have just set my admin theme to "Seven" instead of using "Default theme" => now when using Seven as admin theme, the settings I have changed in the admin/appearance of my custom theme DO save, yes!

pirog commented 10 years ago

Just to confirm. Is the below accurate?

maxplus commented 10 years ago

Yes, that is correct

maxplus commented 10 years ago

Hi, my problems are solved by enabling the Drupal core "update manager" module. => the error message on top disappears => I can set custom theme settings => I can save them, when using my custom Kalatheme as admin theme!

Everything OK!

Look also at this related issue: https://github.com/drupalprojects/kalatheme/issues/123

pirog commented 10 years ago

Very strange.... glad to see enabling updates solves the issue but we should def make sure a user can save their settings in the event that they do not want to enable updates.

@labboy0276 can you look into this and see if the status of the update module somehow prevents the form from being submitted/saved?

The logic should be that you shouldnt be able to do any subtheme related saving (in fact all subtheme options should not be exposed if you dont have updates enabled) but we should def allow the user to still save other things.

@maxplus what kinds of things were you trying to save?

soniktrooth commented 9 years ago

I think this may be related:

When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme.

soniktrooth commented 9 years ago

@labboy0276 suggested we could set the admin theme to kalatheme when it gets enabled: https://www.computerminds.co.uk/articles/setting-default-theme-during-installation

soniktrooth commented 9 years ago

We are already requiring the update module inside of kalatheme_backend_check() and the subtheme form generation is dependant on the return of that function. So I think that covers that part of this issue.

The comment I added is a separate issue: "When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme."

soniktrooth commented 8 years ago

"When trying to generate a sub theme nothing happens unless kalatheme is selected as the admin theme."

Confirmed this is no longer an issue: fixed as part of #215

Everything else seems to be taken care of.