search

drupalprojects / kalatheme

Mirror of http://drupal.org/project/kalatheme provided by hubdrop.
http://hubdrop.org/project/kalatheme
GNU General Public License v2.0
22 stars 29 forks source link

Menu a11y fixes #295

Open soniktrooth opened 7 years ago

soniktrooth commented 7 years ago

We surfaced some a11y fixes for menus in EECS particularly to do with role="menu" and role="menuitem" which are actually meant for web apps. We should remove these from the theme functions they are currently in.

see https://kalamuna.atlassian.net/browse/EECS-510

andrewmallis commented 7 years ago

It would be interesting to see what the a11y people at UCB do say about our standard bootstrap patterns for kalatheme menus.

http://sinberbest.berkeley.edu is a UCB property. Perhaps we can ask for a review of that site?

soniktrooth commented 7 years ago

@andrewmallis I already know what they would say. The fixes that I will make with this issue will bring us inline with vanilla Bootstrap, however there are still some issues with roles. I have doubts that we will have the bandwidth to address too much of this given that BS 4 is close and efforts really need to be concentrated on D8.