dsccommunity / SecurityPolicyDsc

A wrapper around secedit.exe to configure local security policies
MIT License
177 stars 53 forks source link

Added Network_access_Restrict_clients_allowed_to_make_remote_calls_to_SAM #106

Closed jcwalker closed 5 years ago

jcwalker commented 6 years ago

Pull Request (PR) description

Added Network_access_Restrict_clients_allowed_to_make_remote_calls_to_SAM to the SecurityOption resource.

This Pull Request (PR) fixes the following issues

Task list


This change is Reviewable

jcwalker commented 6 years ago

@johlju can help me out with why this build is failing? It fails to create a self signed cert.

johlju commented 6 years ago

I will try to look at it as soon as I can. :) It has been busy at the day job so haven’t been able to get time for the DSC.

johlju commented 6 years ago

Please see this issue: https://github.com/Crypt32/PSPKI/issues/56 When a new release is made by the PSPKI you can kick off the tests again. Alternative chnage appveyor.yml to use a build worker with Windows Server 2016.

johlju commented 6 years ago

A fix was merged to the test framework. Test framework is using the old working PSPKI module. So please close and reopen the PR by choosing Close PR and then press Reopen PR. This will trigger so the tests are run again.

codecov-io commented 6 years ago

Codecov Report

Merging #106 into dev will increase coverage by 6%. The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #106   +/-   ##
==================================
+ Coverage   83%    89%   +6%     
==================================
  Files        5      5           
  Lines      439    491   +52     
==================================
+ Hits       367    441   +74     
+ Misses      72     50   -22
jcwalker commented 6 years ago

@johlju thanks for following up with me on this. The build is successfully running in appveyor now.