dsccommunity / SecurityPolicyDsc

A wrapper around secedit.exe to configure local security policies
MIT License
177 stars 53 forks source link

SecurityOption/AccountPolicy: Add validation attributes to parameters #112

Closed aydeisen closed 5 years ago

aydeisen commented 5 years ago

Pull Request (PR) description

Add ValidateRange and ValidateSet attributes to appropriate parameters in MSFT_AccountPolicy.psm1 and MSFT_SecurityOption.psm1

Add ValueMap to MSFT_SecurityOption.schema.mof for appropriate string properties

This Pull Request (PR) fixes the following issues

Fixes #80

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #112 into dev will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #112   +/-   ##
==================================
  Coverage   89%    89%           
==================================
  Files        5      5           
  Lines      493    493           
==================================
  Hits       443    443           
  Misses      50     50
codecov-io commented 5 years ago

Codecov Report

Merging #112 into dev will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #112   +/-   ##
==================================
  Coverage   89%    89%           
==================================
  Files        5      5           
  Lines      493    493           
==================================
  Hits       443    443           
  Misses      50     50
stale[bot] commented 5 years ago

Labeling this pull request (PR) as abandoned since it has gone 14 days or more since the last update. An abandoned PR can be continued by another contributor. The abandoned label will be removed if work on this PR is taken up again.

gaelcolas commented 5 years ago

I've disabled the Stale bot for now, will also update the labels. Could you rebase your commits off the latest version, please :)

gaelcolas commented 5 years ago

Thanks, hopefully it'll pass the test and I'll get back to it in the next few days unless @jcwalker beats me to it. ;)