dsccommunity / SecurityPolicyDsc

A wrapper around secedit.exe to configure local security policies
MIT License
177 stars 53 forks source link

SecurityPolicyDsc: OptIn to DSC Resource Meta Tests #130

Closed X-Guardian closed 5 years ago

X-Guardian commented 5 years ago

Pull Request (PR) description

This PR opts in to the following DSC Resource meta tests:

To pass the Common Tests - Validate Script Files test, the following files have had their BOM removed:

To pass the Common Tests - Validate Script Files, a Write-Verbose command was added to the Get-TargetResource function of the SecurityTemplate resource.

To pass the Common Tests - Validate Markdown Files test, markdown issues were fixed in the README.md file.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #130 into dev will increase coverage by <1%. The diff coverage is 100%.

Impacted file tree graph

@@         Coverage Diff         @@
##           dev   #130    +/-   ##
===================================
+ Coverage   89%    89%   +<1%     
===================================
  Files        5      5            
  Lines      497    498     +1     
===================================
+ Hits       446    447     +1     
  Misses      51     51
X-Guardian commented 5 years ago

Would someone please review this PR? Thanks.

johlju commented 5 years ago

@jcwalker Do you have time to review this?

X-Guardian commented 5 years ago

I've resolved the conflicts on this PR so it is now ready for review.