dsccommunity / SecurityPolicyDsc

A wrapper around secedit.exe to configure local security policies
MIT License
177 stars 53 forks source link

SecurityPolicyDsc: Move Change Log to CHANGELOG.md and Add Build/Code Coverage Badges #133

Closed X-Guardian closed 5 years ago

X-Guardian commented 5 years ago

Pull Request (PR) description

To conform with other Dsc GitHub repositories, this PR moves the change log to a separate CHANGELOG.md file and adds AppVeyor Build and Code Coverage badges for the master and dev branches to the README.md file.

The PULL_REQUEST_TEMPLATE.md file has also been updated with the new location of the change log.

This Pull Request (PR) fixes the following issues

None

Task list


This change is Reviewable

codecov-io commented 5 years ago

Codecov Report

Merging #133 into dev will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@        Coverage Diff         @@
##           dev   #133   +/-   ##
==================================
  Coverage   89%    89%           
==================================
  Files        5      5           
  Lines      498    498           
==================================
  Hits       447    447           
  Misses      51     51
X-Guardian commented 5 years ago

Can someone review this PR?

X-Guardian commented 5 years ago

Hi @johlju, are you able to finish the review of this PR?

johlju commented 5 years ago

Yep, I can, but later this week I hope I can get to it. 🙂

X-Guardian commented 5 years ago

Cheers, that's great.

X-Guardian commented 5 years ago

Hi @johlju, are you able to finish the review of this PR? I have another bigger PR that greatly improves the documentation in this module that I will submit once this is merged.

johlju commented 5 years ago

Sorry, it is not forgotten. I added a bunch of issues in xWebAdministration for hacktoberfest and it has been crazy there with PR's. Last weekend was to busy with family stuff. But I will get to it this weekend I promise! 😄

johlju commented 5 years ago

I flagged the e-mail notification so I don't forget! :)

X-Guardian commented 5 years ago

Cheers @johlju, no worries!

johlju commented 5 years ago

@jcwalker or @gaelcolas can you please merge this one?