Ensure that returned value includes specified name

[michaeltlombardi]

Prior to this commit, invoking the AccountPolicy resource with the Get method would always return $Null for the Name property; though this property is itself never used by the resource, integrating tools are unable to tell as the Name property is also the Key (as defined in the MOF) for this resource; meaning when comparing the existing state of the resource it will always cause a mismatch between the specified Name and the "actual" representation of the resource on the machine, as reported by the Get-TargetResource function.

This commit modifies the Get-TargetResource function for the AccountPolicy DSC resource to always return the specified Name for the resource in order to prevent churn in secondary tools such as Puppet, Ansible, or Chef.

Pull Request (PR) description

This Pull Request (PR) fixes the following issues

Task list

• [x] Added an entry to the change log under the Unreleased section of the file CHANGELOG.md. Entry should say what was changed and how that affects users (if applicable), and reference the issue being resolved (if applicable).
• [x] Resource documentation added/updated in README.md.
• [x] Resource parameter descriptions added/updated in README.md, schema.mof and comment-based help.
• [x] Comment-based help added/updated.
• [x] Localization strings added/updated in all localization files as appropriate.
• [x] Examples appropriately added/updated.
• [x] Unit tests added/updated. See DSC Community Testing Guidelines.
• [x] Integration tests added/updated (where possible). See DSC Community Testing Guidelines.
• [x] New/changed code adheres to DSC Community Style Guidelines.

---

This change is 

[michaeltlombardi]

Looking over the test suite, I didn't see anything specific to add for this change - I'm happy to cover this in an additional unit test if the maintainers think it necessary (It returns the specified name on the result object in the Get-TargetResource/General operation tests section or something).

Regarding the failing tests, as best I can tell right now, those are failures with the test framework? HQRM tests are failing because something in the framework is passing $Null to the Path parameter of something (see this failure). Similarly, there's a configuration issue at play during the unit tests.

I don't have the familiarity to troubleshoot these at this time, but I'm open to pairing on the problem with a maintainer!

[gaelcolas]

@X-Guardian have you had a chance to look at that?

[gaelcolas]

OH, I see... @michaeltlombardi I think it's a version pinning issue since the release of Pester 5 and ModuleBuilder 1.7.0

In requiredModules.psd1 can you try unpinning ModuleBuilder by setting to latest, and pinning Pester to 4.10.1 ?

Then on a clean PS session, remove the whole output module and build.ps1 again.

[gaelcolas]

leave it to me, there's a bit more to do.

[gaelcolas]

Hopefully #153 will fix your build issue after I merge & you rebase.

[codecov[bot]]

Codecov Report

Merging #152 into master will increase coverage by 0%. The diff coverage is 100%.

@@          Coverage Diff          @@
##           master   #152   +/-   ##
=====================================
  Coverage      89%    89%           
=====================================
  Files           5      5           
  Lines         574    575    +1     
=====================================
+ Hits          516    517    +1     
  Misses         58     58           

[gaelcolas]

The tests are fixed with #153 and I rebased this branch.

I will let @X-Guardian to review this small change as he knows this resource better than I do.

[michaeltlombardi]

Thanks so much, @gaelcolas!