dsccommunity / SecurityPolicyDsc

A wrapper around secedit.exe to configure local security policies
MIT License
177 stars 53 forks source link

BREAKING CHANGE: SecurityOption: append multiline strings with null char and newline #154

Closed mgreenegit closed 3 years ago

mgreenegit commented 3 years ago

Pull Request (PR) description

The intention of this PR is to support multiline settings. The correct format is for each entry to end with a null character and a new line.

Task list


This change is Reviewable

mgreenegit commented 3 years ago

I'm not sure what needs to be done for the build automation to correctly set the version? This could be included in the next 3.0 preview.

codecov[bot] commented 3 years ago

Codecov Report

Merging #154 into master will decrease coverage by 1%. The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #154   +/-   ##
=====================================
- Coverage      89%    88%   -2%     
=====================================
  Files           5      5           
  Lines         575    583    +8     
=====================================
  Hits          517    517           
- Misses         58     66    +8     
johlju commented 3 years ago

I'm not sure what needs to be done for the build automation to correctly set the version? This could be included in the next 3.0 preview.

By adding 'breaking change' to the commit message/title when merging the PR. I will update the PR title so this is done. I will review during the weekend.

mgreenegit commented 3 years ago

In testing this at length I found a more simple approach. Adding new commits. Will not require the additional function but I will add comments to explain why it is doing and why. This is still a breaking change because the expected input becomes a single string instead of a comma delimited array of strings.

mgreenegit commented 3 years ago

This requires a much smaller change than I thought originally. Updating PR.

mgreenegit commented 3 years ago

replaced by #155 155