search

dsccommunity / cNtfsAccessControl

The cNtfsAccessControl DSC resource module.
MIT License
33 stars 10 forks source link

New Resource for Audit Rules (Issue #11) #12

Closed mrhockeymonkey closed 6 years ago

mrhockeymonkey commented 6 years ago

I recently raised https://github.com/SNikalaichyk/cNtfsAccessControl/issues/11 and it turns out this was surprisingly easy. The new resource is basically a copy of cNtfsPermissionEntry but with all the relevant references updated for Audit rules.

There are some things that can be done better here such as moving Resolve-IdentityReference and Set-FileSystemAccessControl into a shared location for both resources to avoid code duplication but i thought it best to start this PR with this so far and get some feedback before altering the code already in place.

Let me know what you think. I have done some testing and all seems to work well.

SNikalaichyk commented 6 years ago

Hi @mrhockeymonkey, Thanks for the contribution! I am going to review it on the weekend.

SNikalaichyk commented 6 years ago

Hello @mrhockeymonkey, unfortunately I haven't found enough time to properly test this PR. Can you please also try to add tests?

mrhockeymonkey commented 6 years ago

Hey @SNikalaichyk sorry I haven't found time to do these tests just yet but I will do so.

mrhockeymonkey commented 6 years ago

Hey @SNikalaichyk , I finally found some time to do those tests. Again - not very inspired they are just re workings of your tests which were very thorough so all credit to you.

SNikalaichyk commented 6 years ago

@mrhockeymonkey Merged, thanks for your contribution! This will soon be released to the PSGallery.

dave-pollock commented 6 years ago

Appreciate both of your effort! Any idea when this will make it to PSGallery?

SNikalaichyk commented 6 years ago

Hi @dave-pollock, I will release it this month.

dave-pollock commented 6 years ago

@SNikalaichyk is there any way we can help get this released? Cheers!

SNikalaichyk commented 6 years ago

Hi @dave-pollock, thanks for reminding me and sorry for the delay!

Here you go: cNtfsAccessControl 1.4.0

PowerShellGet command:

Install-Module -Repository PSGallery -Name cNtfsAccessControl -RequiredVersion 1.4.0 -Verbose
dave-pollock commented 6 years ago

Thanks @SNikalaichyk !!

dave-pollock commented 5 years ago

@mrhockeymonkey @SNikalaichyk I hit the error described here when NoPropagateInherit is set to true in cNtfsAuditRuleInformation: https://github.com/SNikalaichyk/cNtfsAccessControl/issues/5

I've created this PR to apply the same fix: https://github.com/SNikalaichyk/cNtfsAccessControl/pull/14