dschmitz89 / simplenlopt

SciPy style API for NLopt
https://simplenlopt.readthedocs.io/en/latest/
Other
2 stars 0 forks source link

Maintained ? #6

Open lfaucheux opened 2 months ago

lfaucheux commented 2 months ago

Still maintaining ? Surprising that this depot isn't more starred. Rhetorical question: is the scipy interface that outdated (?)

dschmitz89 commented 2 months ago

Glad to hear that this is useful to you!

Everything should work in principle as both NLopt and SciPy have pretty much stable APIs but I am not actively working on this repo anymore. If you are interested in helping out, we could for example start with adding basic testing and CI workflows.

lfaucheux commented 2 months ago

I'm pretty swamped with other commitments currently, less so thanks to you incidentally (!) I could at least point things here and there to debug. For example with the equality_constraints_set function

def equality_constraints_set(constraints):

    for constr in constraints:
        if constr['type'] == 'eq':
            break
            return True  # <--- Never reached

could instead be

def equality_constraints_set(constraints) -> bool:  
    return any(constr['type'] == 'eq' for constr in constraints)

which short-circuits things as first intended.

dschmitz89 commented 2 months ago

That came from the original revrand project codebase which this is based upon, will look into it.

If you need simplenlopt for something serious, I would still suggest to create your own fork to be on the safe side. This repo is seriously undertested and I spend my open source time on SciPy directly nowadays.