search

dslm4515 / CMLFS

Clang-Built Musl Linux From Scratch
MIT License
105 stars 18 forks source link

Patch for musl's utmp.h is incomplete #92

Closed dslm4515 closed 10 months ago

dslm4515 commented 11 months ago

Per MLFS's closed issue, musl's utmp.h should also be patched, not just path.h

Looks like the patch imported from MLFS is missing half of it [patch for utmps.h]

takusuman commented 11 months ago

To be honest, I can not remember if I did this on Copacabana too. I mean, we haven't sourced the patch directly from Musl-LFS, we have made the changes per ourselves. I'll take a look at the documentation that I've written in the last year... Good thing I'm working on it now.

takusuman commented 11 months ago

Eh, just looked at it, we haven't changed and committed the same error. Nice. I'll be taking this fix for Copacabana too. Merci for the observation.

dslm4515 commented 11 months ago

I only noticed it when running the ssh daemon:

wtmp_write: problem writing /dev/null/wtmp: Not a directory

But then after applying the full patch, I still have this error:

wtmp_write: problem writing /run/utmps/wtmp: No such file or directory

... which is no surprise:

$ ls -a /run/utmps/
.  ..  .utmpd-socket  .utmpd-socket.lock  .wtmpd-socket  .wtmpd-socket.lock  utmp

as for some reason my boot script for wtmpd is not creating a wtmp file

takusuman commented 11 months ago

I only noticed it when running the ssh daemon:

Maybe that's another reason for why Heirloom NG tools that depend on utmp weren't working at Copacabana 0.4. With this fix, they will finally do now.

dslm4515 commented 10 months ago

Fixed with commit 160ee2af858050f1e0204b039f3908c2ef54f467