dspace-group / dsV2Gshark

Free Wireshark plugin to analyze ISO15118 V2G communication between electric vehicles (EV) and charging stations (EVSE).
https://www.dspace.com/en/pub/home/news/wireshark-charging-plug-in.cfm
Other
32 stars 8 forks source link

Add support for lua 5.1 #10

Closed ronan22 closed 1 month ago

ronan22 commented 1 month ago

Some OS as openSUSE (until version 15.5) or Fedora (until version 39) build Wireshark with lua version 5.1. So we don't want to use the lua embedded third party (version 5.2) to build the *.so files, because the lua version will not match the lua version embedded in Wireshark.

This commit do not break and change the current build workflow.

To use an alternative lua version install the lua devel package and execute:

export LUAFLAGS="-I$(pkg-config --variable=includedir lua51)" cd V2G_Libraries ./build_all_linux.sh

TGruett commented 1 month ago

Hi, Thanks again for your contribution. I was not aware that there are still Wireshark versions that use Lua 5.1. I've looked at the Wireshark Docu and unfortunately we have to support not only Lua 5.1 and 5.2, but also 5.3 and 5.4 in the future, since Lua 5.4 will be used in Wireshark 4.3.x and higher (applies to Windows as well). So we need to rethink the whole Lua library thing. Maybe there is a way to support all Lua versions 5.1 - 5.4 without distributing different *.so files.

ronan22 commented 1 month ago

OK 1) For now I need the possibility to choose the lua source/version to build and test your plugin on my/some Linux OS. This is why I push this merge request and done it in a way it will not going to disturb your build workflow. (keep this feature optional).

2) Distributing the same binary file for all Linux distribution can be a nightmare. I build and distribute for Linux since a long time now and I will be pleased to help you on that part. We can organize a short meeting for that. You can contact 1) https://github.com/fulup-bzh 2) or me if you are interesting.

We will be happy to assist you.

TGruett commented 1 month ago

We'll keep the issue open until we start working on the binary distribution problem. If we have any further questions we'll get back to you, thanks for your help!